diff options
| author | Maxime Chevallier <maxime.chevallier@smile.fr> | 2017-10-10 04:43:17 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-10-10 05:14:32 -0400 |
| commit | 5a866ec0014b2baa4ecbb1eaa19c835482829d08 (patch) | |
| tree | f9c290d36587220a2c4c263014e74a3d2b110c8f | |
| parent | 6fd6fd68c9e2f3a206a098ef57b1d5548f9d00d1 (diff) | |
spi: a3700: Return correct value on timeout detection
When waiting for transfer completion, a3700_spi_wait_completion
returns a boolean indicating if a timeout occurred.
The function was returning 'true' everytime, failing to detect any
timeout.
This patch makes it return 'false' when a timeout is reached.
Signed-off-by: Maxime Chevallier <maxime.chevallier@smile.fr>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
| -rw-r--r-- | drivers/spi/spi-armada-3700.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c index 9172cb2d2e7a..568e1c65aa82 100644 --- a/drivers/spi/spi-armada-3700.c +++ b/drivers/spi/spi-armada-3700.c | |||
| @@ -387,7 +387,8 @@ static bool a3700_spi_wait_completion(struct spi_device *spi) | |||
| 387 | 387 | ||
| 388 | spireg_write(a3700_spi, A3700_SPI_INT_MASK_REG, 0); | 388 | spireg_write(a3700_spi, A3700_SPI_INT_MASK_REG, 0); |
| 389 | 389 | ||
| 390 | return true; | 390 | /* Timeout was reached */ |
| 391 | return false; | ||
| 391 | } | 392 | } |
| 392 | 393 | ||
| 393 | static bool a3700_spi_transfer_wait(struct spi_device *spi, | 394 | static bool a3700_spi_transfer_wait(struct spi_device *spi, |
