diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2012-11-12 01:19:02 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-11-12 01:19:02 -0500 |
| commit | 5a8477660d9ddc090203736d7271137265cb25bb (patch) | |
| tree | 693128e654759348bf6393eca128acc661aff9da | |
| parent | a736427fa1103158338839813139b20763c7b13e (diff) | |
kill bogus BUG_ON() in do_close_on_exec()
It can be legitimately triggered via procfs access. Now, at least
2 of 3 of get_files_struct() callers in procfs are useless, but
when and if we get rid of those we can always add WARN_ON() here.
BUG_ON() at that spot is simply wrong.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | fs/file.c | 1 |
1 files changed, 0 insertions, 1 deletions
| @@ -685,7 +685,6 @@ void do_close_on_exec(struct files_struct *files) | |||
| 685 | struct fdtable *fdt; | 685 | struct fdtable *fdt; |
| 686 | 686 | ||
| 687 | /* exec unshares first */ | 687 | /* exec unshares first */ |
| 688 | BUG_ON(atomic_read(&files->count) != 1); | ||
| 689 | spin_lock(&files->file_lock); | 688 | spin_lock(&files->file_lock); |
| 690 | for (i = 0; ; i++) { | 689 | for (i = 0; ; i++) { |
| 691 | unsigned long set; | 690 | unsigned long set; |
