diff options
author | Colin Ian King <colin.king@canonical.com> | 2017-06-05 05:04:52 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-06-06 15:13:46 -0400 |
commit | 594238158bf748c285f0a73222cd9b7ccf3c525d (patch) | |
tree | 0fc2e20e8b26f80277c1914f929e5e3ee63746e9 | |
parent | 7b868fed00f6c72d3e0270bcb057b4f26c09e809 (diff) |
net: stmmac: ensure jumbo_frm error return is correctly checked for -ve value
The current comparison of entry < 0 will never be true since entry is an
unsigned integer. Make entry an int to ensure -ve error return values
from the call to jumbo_frm are correctly being caught.
Detected by CoverityScan, CID#1238760 ("Macro compares unsigned to 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index a74c481401c4..e5515c521d86 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | |||
@@ -2947,7 +2947,8 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) | |||
2947 | int i, csum_insertion = 0, is_jumbo = 0; | 2947 | int i, csum_insertion = 0, is_jumbo = 0; |
2948 | u32 queue = skb_get_queue_mapping(skb); | 2948 | u32 queue = skb_get_queue_mapping(skb); |
2949 | int nfrags = skb_shinfo(skb)->nr_frags; | 2949 | int nfrags = skb_shinfo(skb)->nr_frags; |
2950 | unsigned int entry, first_entry; | 2950 | int entry; |
2951 | unsigned int first_entry; | ||
2951 | struct dma_desc *desc, *first; | 2952 | struct dma_desc *desc, *first; |
2952 | struct stmmac_tx_queue *tx_q; | 2953 | struct stmmac_tx_queue *tx_q; |
2953 | unsigned int enh_desc; | 2954 | unsigned int enh_desc; |