diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2016-02-24 10:07:27 -0500 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2016-03-02 10:01:59 -0500 |
commit | 592002f55e6e0b198a01d4a9315f74ddfea1c403 (patch) | |
tree | 9e3c1a3bc79185ef47ce2d4f7710f8f1de8ba28d | |
parent | 78fe39872378b0bef00a91181f1947acb8a08500 (diff) |
virtio_blk: VIRTIO_BLK_F_WCE->VIRTIO_BLK_F_FLUSH
Latest virtio spec says the feature bit name is VIRTIO_BLK_F_FLUSH,
VIRTIO_BLK_F_WCE is the legacy name. virtio blk header says exactly the
reverse - fix that and update driver code to match.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r-- | drivers/block/virtio_blk.c | 11 | ||||
-rw-r--r-- | include/uapi/linux/virtio_blk.h | 6 |
2 files changed, 11 insertions, 6 deletions
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 6ca35495a5be..28cff0d23d82 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers/block/virtio_blk.c | |||
@@ -477,8 +477,13 @@ static int virtblk_get_cache_mode(struct virtio_device *vdev) | |||
477 | err = virtio_cread_feature(vdev, VIRTIO_BLK_F_CONFIG_WCE, | 477 | err = virtio_cread_feature(vdev, VIRTIO_BLK_F_CONFIG_WCE, |
478 | struct virtio_blk_config, wce, | 478 | struct virtio_blk_config, wce, |
479 | &writeback); | 479 | &writeback); |
480 | |||
481 | /* | ||
482 | * If WCE is not configurable and flush is not available, | ||
483 | * assume no writeback cache is in use. | ||
484 | */ | ||
480 | if (err) | 485 | if (err) |
481 | writeback = virtio_has_feature(vdev, VIRTIO_BLK_F_WCE); | 486 | writeback = virtio_has_feature(vdev, VIRTIO_BLK_F_FLUSH); |
482 | 487 | ||
483 | return writeback; | 488 | return writeback; |
484 | } | 489 | } |
@@ -833,14 +838,14 @@ static const struct virtio_device_id id_table[] = { | |||
833 | static unsigned int features_legacy[] = { | 838 | static unsigned int features_legacy[] = { |
834 | VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY, | 839 | VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY, |
835 | VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, VIRTIO_BLK_F_SCSI, | 840 | VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, VIRTIO_BLK_F_SCSI, |
836 | VIRTIO_BLK_F_WCE, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE, | 841 | VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE, |
837 | VIRTIO_BLK_F_MQ, | 842 | VIRTIO_BLK_F_MQ, |
838 | } | 843 | } |
839 | ; | 844 | ; |
840 | static unsigned int features[] = { | 845 | static unsigned int features[] = { |
841 | VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY, | 846 | VIRTIO_BLK_F_SEG_MAX, VIRTIO_BLK_F_SIZE_MAX, VIRTIO_BLK_F_GEOMETRY, |
842 | VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, | 847 | VIRTIO_BLK_F_RO, VIRTIO_BLK_F_BLK_SIZE, |
843 | VIRTIO_BLK_F_WCE, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE, | 848 | VIRTIO_BLK_F_FLUSH, VIRTIO_BLK_F_TOPOLOGY, VIRTIO_BLK_F_CONFIG_WCE, |
844 | VIRTIO_BLK_F_MQ, | 849 | VIRTIO_BLK_F_MQ, |
845 | }; | 850 | }; |
846 | 851 | ||
diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h index 19c66fcbab8a..9ebe4d968dd5 100644 --- a/include/uapi/linux/virtio_blk.h +++ b/include/uapi/linux/virtio_blk.h | |||
@@ -43,11 +43,11 @@ | |||
43 | #ifndef VIRTIO_BLK_NO_LEGACY | 43 | #ifndef VIRTIO_BLK_NO_LEGACY |
44 | #define VIRTIO_BLK_F_BARRIER 0 /* Does host support barriers? */ | 44 | #define VIRTIO_BLK_F_BARRIER 0 /* Does host support barriers? */ |
45 | #define VIRTIO_BLK_F_SCSI 7 /* Supports scsi command passthru */ | 45 | #define VIRTIO_BLK_F_SCSI 7 /* Supports scsi command passthru */ |
46 | #define VIRTIO_BLK_F_WCE 9 /* Writeback mode enabled after reset */ | 46 | #define VIRTIO_BLK_F_FLUSH 9 /* Flush command supported */ |
47 | #define VIRTIO_BLK_F_CONFIG_WCE 11 /* Writeback mode available in config */ | 47 | #define VIRTIO_BLK_F_CONFIG_WCE 11 /* Writeback mode available in config */ |
48 | #ifndef __KERNEL__ | 48 | #ifndef __KERNEL__ |
49 | /* Old (deprecated) name for VIRTIO_BLK_F_WCE. */ | 49 | /* Old (deprecated) name for VIRTIO_BLK_F_FLUSH. */ |
50 | #define VIRTIO_BLK_F_FLUSH VIRTIO_BLK_F_WCE | 50 | #define VIRTIO_BLK_F_WCE VIRTIO_BLK_F_FLUSH |
51 | #endif | 51 | #endif |
52 | #endif /* !VIRTIO_BLK_NO_LEGACY */ | 52 | #endif /* !VIRTIO_BLK_NO_LEGACY */ |
53 | 53 | ||