diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-04-25 05:04:54 -0400 |
---|---|---|
committer | Boris Brezillon <boris.brezillon@free-electrons.com> | 2016-06-01 09:59:36 -0400 |
commit | 58a2ab3af722550b2e4e8155eb08660e16c20ee6 (patch) | |
tree | 5685d16d65ee605b438678179238303128a964da | |
parent | c2e4c99444f418b3c3b13b58dad4d951aa2f7f1b (diff) |
drm: atmel-hlcdc: fix a NULL check
If kmalloc() returned NULL we would end up dereferencing "state" a
couple lines later.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
-rw-r--r-- | drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index ac4e0632c2de..bd12231ab0cd 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | |||
@@ -414,8 +414,9 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) | |||
414 | return NULL; | 414 | return NULL; |
415 | 415 | ||
416 | state = kmalloc(sizeof(*state), GFP_KERNEL); | 416 | state = kmalloc(sizeof(*state), GFP_KERNEL); |
417 | if (state) | 417 | if (!state) |
418 | __drm_atomic_helper_crtc_duplicate_state(crtc, &state->base); | 418 | return NULL; |
419 | __drm_atomic_helper_crtc_duplicate_state(crtc, &state->base); | ||
419 | 420 | ||
420 | cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state); | 421 | cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state); |
421 | state->output_mode = cur->output_mode; | 422 | state->output_mode = cur->output_mode; |