aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBhumika Goyal <bhumirks@gmail.com>2017-08-02 05:10:06 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-08-28 10:55:48 -0400
commit57daedf812f1fe8b02fab1628b6f4e639466136c (patch)
treef7d85f9693bb9af5d9f1a88ad739dcaaa9a4c667
parente3b9c5cea38bd3735dcc7dea571d1f57cf510ae9 (diff)
MISC: add const to bin_attribute structures
Add const to bin_attribute structures as they are only passed to the functions sysfs_{remove/create}_bin_file. The arguments passed are of type const, so declare the structures to be const. Done using Coccinelle. @m disable optional_qualifier@ identifier s; position p; @@ static struct bin_attribute s@p={...}; @okay1@ position p; identifier m.s; @@ ( sysfs_create_bin_file(...,&s@p,...) | sysfs_remove_bin_file(...,&s@p,...) ) @bad@ position p!={m.p,okay1.p}; identifier m.s; @@ s@p @change depends on !bad disable optional_qualifier@ identifier m.s; @@ static +const struct bin_attribute s={...}; Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/ds1682.c2
-rw-r--r--drivers/misc/eeprom/eeprom.c2
-rw-r--r--drivers/misc/eeprom/max6875.c2
-rw-r--r--drivers/misc/pch_phub.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c
index 28bb495f0cf1..7231260ac287 100644
--- a/drivers/misc/ds1682.c
+++ b/drivers/misc/ds1682.c
@@ -173,7 +173,7 @@ static ssize_t ds1682_eeprom_write(struct file *filp, struct kobject *kobj,
173 return count; 173 return count;
174} 174}
175 175
176static struct bin_attribute ds1682_eeprom_attr = { 176static const struct bin_attribute ds1682_eeprom_attr = {
177 .attr = { 177 .attr = {
178 .name = "eeprom", 178 .name = "eeprom",
179 .mode = S_IRUGO | S_IWUSR, 179 .mode = S_IRUGO | S_IWUSR,
diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
index 2fad790db3bf..60e3d91b5e03 100644
--- a/drivers/misc/eeprom/eeprom.c
+++ b/drivers/misc/eeprom/eeprom.c
@@ -114,7 +114,7 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,
114 return count; 114 return count;
115} 115}
116 116
117static struct bin_attribute eeprom_attr = { 117static const struct bin_attribute eeprom_attr = {
118 .attr = { 118 .attr = {
119 .name = "eeprom", 119 .name = "eeprom",
120 .mode = S_IRUGO, 120 .mode = S_IRUGO,
diff --git a/drivers/misc/eeprom/max6875.c b/drivers/misc/eeprom/max6875.c
index e4dd93b2518c..0e32709d1022 100644
--- a/drivers/misc/eeprom/max6875.c
+++ b/drivers/misc/eeprom/max6875.c
@@ -124,7 +124,7 @@ static ssize_t max6875_read(struct file *filp, struct kobject *kobj,
124 return count; 124 return count;
125} 125}
126 126
127static struct bin_attribute user_eeprom_attr = { 127static const struct bin_attribute user_eeprom_attr = {
128 .attr = { 128 .attr = {
129 .name = "eeprom", 129 .name = "eeprom",
130 .mode = S_IRUGO, 130 .mode = S_IRUGO,
diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c
index 2ffacda884cd..540845651b8c 100644
--- a/drivers/misc/pch_phub.c
+++ b/drivers/misc/pch_phub.c
@@ -659,7 +659,7 @@ static ssize_t store_pch_mac(struct device *dev, struct device_attribute *attr,
659 659
660static DEVICE_ATTR(pch_mac, S_IRUGO | S_IWUSR, show_pch_mac, store_pch_mac); 660static DEVICE_ATTR(pch_mac, S_IRUGO | S_IWUSR, show_pch_mac, store_pch_mac);
661 661
662static struct bin_attribute pch_bin_attr = { 662static const struct bin_attribute pch_bin_attr = {
663 .attr = { 663 .attr = {
664 .name = "pch_firmware", 664 .name = "pch_firmware",
665 .mode = S_IRUGO | S_IWUSR, 665 .mode = S_IRUGO | S_IWUSR,