diff options
author | Ming Lei <ming.lei@canonical.com> | 2015-11-23 21:35:29 -0500 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2015-11-23 22:16:51 -0500 |
commit | 578270bfbd2803dc7b0b03fbc2ac119efbc73195 (patch) | |
tree | b326c3879cfde7498f2c3c257951f5ae67b19502 | |
parent | b094f89ca42fbb8ce40174d5f85ca8430e499da6 (diff) |
block: fix segment split
Inside blk_bio_segment_split(), previous bvec pointer(bvprvp)
always points to the iterator local variable, which is obviously
wrong, so fix it by pointing to the local variable of 'bvprv'.
Fixes: 5014c311baa2b(block: fix bogus compiler warnings in blk-merge.c)
Cc: stable@kernel.org #4.3
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Reported-by: Mark Salter <msalter@redhat.com>
Tested-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
Tested-by: Mark Salter <msalter@redhat.com>
Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r-- | block/blk-merge.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/block/blk-merge.c b/block/blk-merge.c index de5716d8e525..f2efe8ae75bb 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c | |||
@@ -98,7 +98,7 @@ static struct bio *blk_bio_segment_split(struct request_queue *q, | |||
98 | 98 | ||
99 | seg_size += bv.bv_len; | 99 | seg_size += bv.bv_len; |
100 | bvprv = bv; | 100 | bvprv = bv; |
101 | bvprvp = &bv; | 101 | bvprvp = &bvprv; |
102 | sectors += bv.bv_len >> 9; | 102 | sectors += bv.bv_len >> 9; |
103 | continue; | 103 | continue; |
104 | } | 104 | } |
@@ -108,7 +108,7 @@ new_segment: | |||
108 | 108 | ||
109 | nsegs++; | 109 | nsegs++; |
110 | bvprv = bv; | 110 | bvprv = bv; |
111 | bvprvp = &bv; | 111 | bvprvp = &bvprv; |
112 | seg_size = bv.bv_len; | 112 | seg_size = bv.bv_len; |
113 | sectors += bv.bv_len >> 9; | 113 | sectors += bv.bv_len >> 9; |
114 | } | 114 | } |