aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Auld <matthew.auld@intel.com>2016-08-02 04:36:53 -0400
committerJoonas Lahtinen <joonas.lahtinen@linux.intel.com>2016-08-05 06:16:55 -0400
commit575e3ccbce4582395d57612b289178bad4af3be8 (patch)
treed7d6fc171b205b31932b596415e400a556e23833
parent209b3f7ed0e865ef0f3ffde3d623703019daeafc (diff)
drm/i915: fix WaInsertDummyPushConstPs
As pointed out by Chris Harris, we are using the wrong WA name, it should in fact be WaToEnableHwFixForPushConstHWBug, also it should be applied from C0 onwards for both BXT and KBL. Fixes: 7b9005cd45f3 ("drm/i915: Add WaInsertDummyPushConstP for bxt and kbl") Cc: Chris Harris <chris.harris@intel.com> Cc: Mika Kuoppala <mika.kuoppala@intel.com> Reported-by: Chris Harris <chris.harris@intel.com> Signed-off-by: Matthew Auld <matthew.auld@intel.com> Reviewed-by: Arun Siluvery <arun.siluvery@linux.intel.com> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1470127013-29653-1-git-send-email-matthew.auld@intel.com
-rw-r--r--drivers/gpu/drm/i915/intel_ringbuffer.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 322274a239e4..e08a1e1b04e4 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
@@ -1149,8 +1149,8 @@ static int bxt_init_workarounds(struct intel_engine_cs *engine)
1149 I915_WRITE(GEN8_L3SQCREG1, L3_GENERAL_PRIO_CREDITS(62) | 1149 I915_WRITE(GEN8_L3SQCREG1, L3_GENERAL_PRIO_CREDITS(62) |
1150 L3_HIGH_PRIO_CREDITS(2)); 1150 L3_HIGH_PRIO_CREDITS(2));
1151 1151
1152 /* WaInsertDummyPushConstPs:bxt */ 1152 /* WaToEnableHwFixForPushConstHWBug:bxt */
1153 if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_B0)) 1153 if (IS_BXT_REVID(dev_priv, BXT_REVID_C0, REVID_FOREVER))
1154 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2, 1154 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
1155 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION); 1155 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
1156 1156
@@ -1193,8 +1193,8 @@ static int kbl_init_workarounds(struct intel_engine_cs *engine)
1193 I915_WRITE(GEN8_L3SQCREG4, I915_READ(GEN8_L3SQCREG4) | 1193 I915_WRITE(GEN8_L3SQCREG4, I915_READ(GEN8_L3SQCREG4) |
1194 GEN8_LQSC_RO_PERF_DIS); 1194 GEN8_LQSC_RO_PERF_DIS);
1195 1195
1196 /* WaInsertDummyPushConstPs:kbl */ 1196 /* WaToEnableHwFixForPushConstHWBug:kbl */
1197 if (IS_KBL_REVID(dev_priv, 0, KBL_REVID_B0)) 1197 if (IS_KBL_REVID(dev_priv, KBL_REVID_C0, REVID_FOREVER))
1198 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2, 1198 WA_SET_BIT_MASKED(COMMON_SLICE_CHICKEN2,
1199 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION); 1199 GEN8_SBE_DISABLE_REPLAY_BUF_OPTIMIZATION);
1200 1200