aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2018-10-17 03:20:04 -0400
committerDoug Ledford <dledford@redhat.com>2018-10-17 11:42:58 -0400
commit56e027a604c80b1106786f8426e7cc5dbacb53b2 (patch)
tree09a444dda575be598deb09b021b4e570d514487a
parent6f4bc0ea682b59d7013cbc5ced2d4dd73067a33f (diff)
ib_srp: Remove WARN_ON in srp_terminate_io()
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Jens Axboe <axboe@kernel.dk> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.com> Acked-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Doug Ledford <dledford@redhat.com>
-rw-r--r--drivers/infiniband/ulp/srp/ib_srp.c9
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 36ade9ae7dde..eed0eb3bb04c 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -1330,17 +1330,8 @@ static void srp_terminate_io(struct srp_rport *rport)
1330{ 1330{
1331 struct srp_target_port *target = rport->lld_data; 1331 struct srp_target_port *target = rport->lld_data;
1332 struct srp_rdma_ch *ch; 1332 struct srp_rdma_ch *ch;
1333 struct Scsi_Host *shost = target->scsi_host;
1334 struct scsi_device *sdev;
1335 int i, j; 1333 int i, j;
1336 1334
1337 /*
1338 * Invoking srp_terminate_io() while srp_queuecommand() is running
1339 * is not safe. Hence the warning statement below.
1340 */
1341 shost_for_each_device(sdev, shost)
1342 WARN_ON_ONCE(sdev->request_queue->request_fn_active);
1343
1344 for (i = 0; i < target->ch_count; i++) { 1335 for (i = 0; i < target->ch_count; i++) {
1345 ch = &target->ch[i]; 1336 ch = &target->ch[i];
1346 1337