aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZefir Kurtisi <zefir.kurtisi@neratec.com>2015-10-20 08:19:26 -0400
committerKalle Valo <kvalo@codeaurora.org>2015-10-28 14:57:13 -0400
commit56bae464275ac57cbf993f3ed15e96d6e1ec00a2 (patch)
tree09636ae24ad9c3a10d0b681a52ba13b552912906
parent989b8376f33721f7206dd058330da05972a71384 (diff)
ath9k: fix phyerror codes
Some of the ath9k_phyerr enums were wrong from the beginning (and even before). Most of the time the codes were used for counters to be displayed over debugfs, which made this a non-functional issue. Some (e.g. ATH9K_PHYERR_FALSE_RADAR_EXT) are used for radar detection and require the correct code to work as intended. This patch includes: a) fixes ATH9K_PHYERR_FALSE_RADAR_EXT: 24 => 36 ATH9K_PHYERR_CCK_LENGTH_ILLEGAL: 32 => 28 ATH9K_PHYERR_CCK_POWER_DROP: 33 => 29 ATH9K_PHYERR_HT_CRC_ERROR: 34 => 32 ATH9K_PHYERR_HT_LENGTH_ILLEGAL: 35 => 33 ATH9K_PHYERR_HT_RATE_ILLEGAL: 36 => 34 b) extensions ATH9K_PHYERR_CCK_BLOCKER = 24 ATH9K_PHYERR_HT_ZLF = 35 ATH9K_PHYERR_GREEN_FIELD = 37 Aside from the correction and completion made in the enum, the patch also extends the display of the related counters in the debugfs. Signed-off-by: Zefir Kurtisi <zefir.kurtisi@neratec.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
-rw-r--r--drivers/net/wireless/ath/ath9k/common-debug.c14
-rw-r--r--drivers/net/wireless/ath/ath9k/mac.h18
2 files changed, 22 insertions, 10 deletions
diff --git a/drivers/net/wireless/ath/ath9k/common-debug.c b/drivers/net/wireless/ath/ath9k/common-debug.c
index 3b289f933405..84afcf78151f 100644
--- a/drivers/net/wireless/ath/ath9k/common-debug.c
+++ b/drivers/net/wireless/ath/ath9k/common-debug.c
@@ -207,6 +207,7 @@ static ssize_t read_file_phy_err(struct file *file, char __user *user_buf,
207 PHY_ERR("RADAR ERR", ATH9K_PHYERR_RADAR); 207 PHY_ERR("RADAR ERR", ATH9K_PHYERR_RADAR);
208 PHY_ERR("SERVICE ERR", ATH9K_PHYERR_SERVICE); 208 PHY_ERR("SERVICE ERR", ATH9K_PHYERR_SERVICE);
209 PHY_ERR("TOR ERR", ATH9K_PHYERR_TOR); 209 PHY_ERR("TOR ERR", ATH9K_PHYERR_TOR);
210
210 PHY_ERR("OFDM-TIMING ERR", ATH9K_PHYERR_OFDM_TIMING); 211 PHY_ERR("OFDM-TIMING ERR", ATH9K_PHYERR_OFDM_TIMING);
211 PHY_ERR("OFDM-SIGNAL-PARITY ERR", ATH9K_PHYERR_OFDM_SIGNAL_PARITY); 212 PHY_ERR("OFDM-SIGNAL-PARITY ERR", ATH9K_PHYERR_OFDM_SIGNAL_PARITY);
212 PHY_ERR("OFDM-RATE ERR", ATH9K_PHYERR_OFDM_RATE_ILLEGAL); 213 PHY_ERR("OFDM-RATE ERR", ATH9K_PHYERR_OFDM_RATE_ILLEGAL);
@@ -214,17 +215,24 @@ static ssize_t read_file_phy_err(struct file *file, char __user *user_buf,
214 PHY_ERR("OFDM-POWER-DROP ERR", ATH9K_PHYERR_OFDM_POWER_DROP); 215 PHY_ERR("OFDM-POWER-DROP ERR", ATH9K_PHYERR_OFDM_POWER_DROP);
215 PHY_ERR("OFDM-SERVICE ERR", ATH9K_PHYERR_OFDM_SERVICE); 216 PHY_ERR("OFDM-SERVICE ERR", ATH9K_PHYERR_OFDM_SERVICE);
216 PHY_ERR("OFDM-RESTART ERR", ATH9K_PHYERR_OFDM_RESTART); 217 PHY_ERR("OFDM-RESTART ERR", ATH9K_PHYERR_OFDM_RESTART);
217 PHY_ERR("FALSE-RADAR-EXT ERR", ATH9K_PHYERR_FALSE_RADAR_EXT); 218
219 PHY_ERR("CCK-BLOCKER ERR", ATH9K_PHYERR_CCK_BLOCKER);
218 PHY_ERR("CCK-TIMING ERR", ATH9K_PHYERR_CCK_TIMING); 220 PHY_ERR("CCK-TIMING ERR", ATH9K_PHYERR_CCK_TIMING);
219 PHY_ERR("CCK-HEADER-CRC ERR", ATH9K_PHYERR_CCK_HEADER_CRC); 221 PHY_ERR("CCK-HEADER-CRC ERR", ATH9K_PHYERR_CCK_HEADER_CRC);
220 PHY_ERR("CCK-RATE ERR", ATH9K_PHYERR_CCK_RATE_ILLEGAL); 222 PHY_ERR("CCK-RATE ERR", ATH9K_PHYERR_CCK_RATE_ILLEGAL);
221 PHY_ERR("CCK-SERVICE ERR", ATH9K_PHYERR_CCK_SERVICE);
222 PHY_ERR("CCK-RESTART ERR", ATH9K_PHYERR_CCK_RESTART);
223 PHY_ERR("CCK-LENGTH ERR", ATH9K_PHYERR_CCK_LENGTH_ILLEGAL); 223 PHY_ERR("CCK-LENGTH ERR", ATH9K_PHYERR_CCK_LENGTH_ILLEGAL);
224 PHY_ERR("CCK-POWER-DROP ERR", ATH9K_PHYERR_CCK_POWER_DROP); 224 PHY_ERR("CCK-POWER-DROP ERR", ATH9K_PHYERR_CCK_POWER_DROP);
225 PHY_ERR("CCK-SERVICE ERR", ATH9K_PHYERR_CCK_SERVICE);
226 PHY_ERR("CCK-RESTART ERR", ATH9K_PHYERR_CCK_RESTART);
227
225 PHY_ERR("HT-CRC ERR", ATH9K_PHYERR_HT_CRC_ERROR); 228 PHY_ERR("HT-CRC ERR", ATH9K_PHYERR_HT_CRC_ERROR);
226 PHY_ERR("HT-LENGTH ERR", ATH9K_PHYERR_HT_LENGTH_ILLEGAL); 229 PHY_ERR("HT-LENGTH ERR", ATH9K_PHYERR_HT_LENGTH_ILLEGAL);
227 PHY_ERR("HT-RATE ERR", ATH9K_PHYERR_HT_RATE_ILLEGAL); 230 PHY_ERR("HT-RATE ERR", ATH9K_PHYERR_HT_RATE_ILLEGAL);
231 PHY_ERR("HT-ZLF ERR", ATH9K_PHYERR_HT_ZLF);
232
233 PHY_ERR("FALSE-RADAR-EXT ERR", ATH9K_PHYERR_FALSE_RADAR_EXT);
234 PHY_ERR("GREEN-FIELD ERR", ATH9K_PHYERR_GREEN_FIELD);
235 PHY_ERR("SPECTRAL ERR", ATH9K_PHYERR_SPECTRAL);
228 236
229 if (len > size) 237 if (len > size)
230 len = size; 238 len = size;
diff --git a/drivers/net/wireless/ath/ath9k/mac.h b/drivers/net/wireless/ath/ath9k/mac.h
index e55fa11894b6..7fbf7f965f61 100644
--- a/drivers/net/wireless/ath/ath9k/mac.h
+++ b/drivers/net/wireless/ath/ath9k/mac.h
@@ -209,21 +209,25 @@ enum ath9k_phyerr {
209 ATH9K_PHYERR_OFDM_POWER_DROP = 21, 209 ATH9K_PHYERR_OFDM_POWER_DROP = 21,
210 ATH9K_PHYERR_OFDM_SERVICE = 22, 210 ATH9K_PHYERR_OFDM_SERVICE = 22,
211 ATH9K_PHYERR_OFDM_RESTART = 23, 211 ATH9K_PHYERR_OFDM_RESTART = 23,
212 ATH9K_PHYERR_FALSE_RADAR_EXT = 24,
213 212
213 ATH9K_PHYERR_CCK_BLOCKER = 24,
214 ATH9K_PHYERR_CCK_TIMING = 25, 214 ATH9K_PHYERR_CCK_TIMING = 25,
215 ATH9K_PHYERR_CCK_HEADER_CRC = 26, 215 ATH9K_PHYERR_CCK_HEADER_CRC = 26,
216 ATH9K_PHYERR_CCK_RATE_ILLEGAL = 27, 216 ATH9K_PHYERR_CCK_RATE_ILLEGAL = 27,
217 ATH9K_PHYERR_CCK_LENGTH_ILLEGAL = 28,
218 ATH9K_PHYERR_CCK_POWER_DROP = 29,
217 ATH9K_PHYERR_CCK_SERVICE = 30, 219 ATH9K_PHYERR_CCK_SERVICE = 30,
218 ATH9K_PHYERR_CCK_RESTART = 31, 220 ATH9K_PHYERR_CCK_RESTART = 31,
219 ATH9K_PHYERR_CCK_LENGTH_ILLEGAL = 32,
220 ATH9K_PHYERR_CCK_POWER_DROP = 33,
221 221
222 ATH9K_PHYERR_HT_CRC_ERROR = 34, 222 ATH9K_PHYERR_HT_CRC_ERROR = 32,
223 ATH9K_PHYERR_HT_LENGTH_ILLEGAL = 35, 223 ATH9K_PHYERR_HT_LENGTH_ILLEGAL = 33,
224 ATH9K_PHYERR_HT_RATE_ILLEGAL = 36, 224 ATH9K_PHYERR_HT_RATE_ILLEGAL = 34,
225 ATH9K_PHYERR_HT_ZLF = 35,
226
227 ATH9K_PHYERR_FALSE_RADAR_EXT = 36,
228 ATH9K_PHYERR_GREEN_FIELD = 37,
229 ATH9K_PHYERR_SPECTRAL = 38,
225 230
226 ATH9K_PHYERR_SPECTRAL = 38,
227 ATH9K_PHYERR_MAX = 39, 231 ATH9K_PHYERR_MAX = 39,
228}; 232};
229 233