diff options
author | LABBE Corentin <clabbe.montjoie@gmail.com> | 2015-11-11 15:27:34 -0500 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2015-11-17 08:39:17 -0500 |
commit | 56880a243c85668762dfec69b878862f86be6f04 (patch) | |
tree | 9c051d9ff44218f26a21339f72bfa3f62334f86d | |
parent | 8005c49d9aea74d382f474ce11afbbc7d7130bec (diff) |
gpio: 74xx: fix a possible NULL dereference
of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 132:
priv->flags = (uintptr_t) of_id->data;
Reported-by: coverity (CID 1324141)
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
-rw-r--r-- | drivers/gpio/gpio-74xx-mmio.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c index 6ed7c0fb3378..6b186829087c 100644 --- a/drivers/gpio/gpio-74xx-mmio.c +++ b/drivers/gpio/gpio-74xx-mmio.c | |||
@@ -113,13 +113,16 @@ static int mmio_74xx_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) | |||
113 | 113 | ||
114 | static int mmio_74xx_gpio_probe(struct platform_device *pdev) | 114 | static int mmio_74xx_gpio_probe(struct platform_device *pdev) |
115 | { | 115 | { |
116 | const struct of_device_id *of_id = | 116 | const struct of_device_id *of_id; |
117 | of_match_device(mmio_74xx_gpio_ids, &pdev->dev); | ||
118 | struct mmio_74xx_gpio_priv *priv; | 117 | struct mmio_74xx_gpio_priv *priv; |
119 | struct resource *res; | 118 | struct resource *res; |
120 | void __iomem *dat; | 119 | void __iomem *dat; |
121 | int err; | 120 | int err; |
122 | 121 | ||
122 | of_id = of_match_device(mmio_74xx_gpio_ids, &pdev->dev); | ||
123 | if (!of_id) | ||
124 | return -ENODEV; | ||
125 | |||
123 | priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); | 126 | priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); |
124 | if (!priv) | 127 | if (!priv) |
125 | return -ENOMEM; | 128 | return -ENOMEM; |