aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2017-10-04 04:03:04 -0400
committerThomas Gleixner <tglx@linutronix.de>2017-10-04 04:53:54 -0400
commit5587185ddb4b9f413299dfec0a022ad0212513e8 (patch)
tree677c5d780663399f1e901dbafe1f9051c57ca9ea
parent34ddaa3e5c0096fef52485186c7eb6cf56ddc686 (diff)
watchdog/core: Rename some softlockup_* functions
The function names made sense up to the point where the watchdog (re)configuration was unified to use softlockup_reconfigure_threads() for all configuration purposes. But that includes scenarios which solely configure the nmi watchdog. Rename softlockup_reconfigure_threads() and softlockup_init_threads() so the function names match the functionality. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Linus Torvalds <torvalds@linuxfoundation.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Don Zickus <dzickus@redhat.com>
-rw-r--r--kernel/watchdog.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 5c6fb7cd9ae8..d241bd99cee1 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -551,7 +551,7 @@ static void softlockup_unpark_threads(void)
551 softlockup_update_smpboot_threads(); 551 softlockup_update_smpboot_threads();
552} 552}
553 553
554static void softlockup_reconfigure_threads(void) 554static void lockup_detector_reconfigure(void)
555{ 555{
556 cpus_read_lock(); 556 cpus_read_lock();
557 watchdog_nmi_stop(); 557 watchdog_nmi_stop();
@@ -570,13 +570,13 @@ static void softlockup_reconfigure_threads(void)
570} 570}
571 571
572/* 572/*
573 * Create the watchdog thread infrastructure. 573 * Create the watchdog thread infrastructure and configure the detector(s).
574 * 574 *
575 * The threads are not unparked as watchdog_allowed_mask is empty. When 575 * The threads are not unparked as watchdog_allowed_mask is empty. When
576 * the threads are sucessfully initialized, take the proper locks and 576 * the threads are sucessfully initialized, take the proper locks and
577 * unpark the threads in the watchdog_cpumask if the watchdog is enabled. 577 * unpark the threads in the watchdog_cpumask if the watchdog is enabled.
578 */ 578 */
579static __init void softlockup_init_threads(void) 579static __init void lockup_detector_setup(void)
580{ 580{
581 int ret; 581 int ret;
582 582
@@ -599,7 +599,7 @@ static __init void softlockup_init_threads(void)
599 599
600 mutex_lock(&watchdog_mutex); 600 mutex_lock(&watchdog_mutex);
601 softlockup_threads_initialized = true; 601 softlockup_threads_initialized = true;
602 softlockup_reconfigure_threads(); 602 lockup_detector_reconfigure();
603 mutex_unlock(&watchdog_mutex); 603 mutex_unlock(&watchdog_mutex);
604} 604}
605 605
@@ -608,7 +608,7 @@ static inline int watchdog_park_threads(void) { return 0; }
608static inline void watchdog_unpark_threads(void) { } 608static inline void watchdog_unpark_threads(void) { }
609static inline int watchdog_enable_all_cpus(void) { return 0; } 609static inline int watchdog_enable_all_cpus(void) { return 0; }
610static inline void watchdog_disable_all_cpus(void) { } 610static inline void watchdog_disable_all_cpus(void) { }
611static void softlockup_reconfigure_threads(void) 611static void lockup_detector_reconfigure(void)
612{ 612{
613 cpus_read_lock(); 613 cpus_read_lock();
614 watchdog_nmi_stop(); 614 watchdog_nmi_stop();
@@ -616,9 +616,9 @@ static void softlockup_reconfigure_threads(void)
616 watchdog_nmi_start(); 616 watchdog_nmi_start();
617 cpus_read_unlock(); 617 cpus_read_unlock();
618} 618}
619static inline void softlockup_init_threads(void) 619static inline void lockup_detector_setup(void)
620{ 620{
621 softlockup_reconfigure_threads(); 621 lockup_detector_reconfigure();
622} 622}
623#endif /* !CONFIG_SOFTLOCKUP_DETECTOR */ 623#endif /* !CONFIG_SOFTLOCKUP_DETECTOR */
624 624
@@ -658,7 +658,7 @@ static void proc_watchdog_update(void)
658{ 658{
659 /* Remove impossible cpus to keep sysctl output clean. */ 659 /* Remove impossible cpus to keep sysctl output clean. */
660 cpumask_and(&watchdog_cpumask, &watchdog_cpumask, cpu_possible_mask); 660 cpumask_and(&watchdog_cpumask, &watchdog_cpumask, cpu_possible_mask);
661 softlockup_reconfigure_threads(); 661 lockup_detector_reconfigure();
662} 662}
663 663
664/* 664/*
@@ -785,5 +785,5 @@ void __init lockup_detector_init(void)
785 785
786 if (!watchdog_nmi_probe()) 786 if (!watchdog_nmi_probe())
787 nmi_watchdog_available = true; 787 nmi_watchdog_available = true;
788 softlockup_init_threads(); 788 lockup_detector_setup();
789} 789}