diff options
author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2015-06-13 23:49:31 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2015-06-15 07:36:44 -0400 |
commit | 554d8983a07d853bc4761c575db2f1bbb2f14372 (patch) | |
tree | 075d785a7e1b3d53ea2a6006b42b2453daee8490 | |
parent | 3e254b16b65dbbcc2528781070e1be0f7945f220 (diff) |
ALSA: bebob: obsolete string literal expression for clock source
The old string literals were completely replaced by new normalized
representation.
This commit obsoletes it.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r-- | sound/firewire/bebob/bebob.h | 1 | ||||
-rw-r--r-- | sound/firewire/bebob/bebob_focusrite.c | 12 | ||||
-rw-r--r-- | sound/firewire/bebob/bebob_maudio.c | 10 | ||||
-rw-r--r-- | sound/firewire/bebob/bebob_terratec.c | 8 | ||||
-rw-r--r-- | sound/firewire/bebob/bebob_yamaha.c | 2 |
5 files changed, 6 insertions, 27 deletions
diff --git a/sound/firewire/bebob/bebob.h b/sound/firewire/bebob/bebob.h index 73317d88cc80..11362b30ee5b 100644 --- a/sound/firewire/bebob/bebob.h +++ b/sound/firewire/bebob/bebob.h | |||
@@ -49,7 +49,6 @@ struct snd_bebob_stream_formation { | |||
49 | extern const unsigned int snd_bebob_rate_table[SND_BEBOB_STRM_FMT_ENTRIES]; | 49 | extern const unsigned int snd_bebob_rate_table[SND_BEBOB_STRM_FMT_ENTRIES]; |
50 | 50 | ||
51 | /* device specific operations */ | 51 | /* device specific operations */ |
52 | #define SND_BEBOB_CLOCK_INTERNAL "Internal" | ||
53 | enum snd_bebob_clock_type { | 52 | enum snd_bebob_clock_type { |
54 | SND_BEBOB_CLOCK_TYPE_INTERNAL = 0, | 53 | SND_BEBOB_CLOCK_TYPE_INTERNAL = 0, |
55 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, | 54 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, |
diff --git a/sound/firewire/bebob/bebob_focusrite.c b/sound/firewire/bebob/bebob_focusrite.c index 45c8f76d8187..a1a39494ea6c 100644 --- a/sound/firewire/bebob/bebob_focusrite.c +++ b/sound/firewire/bebob/bebob_focusrite.c | |||
@@ -103,17 +103,11 @@ saffire_write_quad(struct snd_bebob *bebob, u64 offset, u32 value) | |||
103 | &data, sizeof(__be32), 0); | 103 | &data, sizeof(__be32), 0); |
104 | } | 104 | } |
105 | 105 | ||
106 | static const char *const saffirepro_10_clk_src_labels[] = { | ||
107 | SND_BEBOB_CLOCK_INTERNAL, "S/PDIF", "Word Clock" | ||
108 | }; | ||
109 | static enum snd_bebob_clock_type saffirepro_10_clk_src_types[] = { | 106 | static enum snd_bebob_clock_type saffirepro_10_clk_src_types[] = { |
110 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 107 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
111 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ | 108 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ |
112 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* Word Clock */ | 109 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* Word Clock */ |
113 | }; | 110 | }; |
114 | static const char *const saffirepro_26_clk_src_labels[] = { | ||
115 | SND_BEBOB_CLOCK_INTERNAL, "S/PDIF", "ADAT1", "ADAT2", "Word Clock" | ||
116 | }; | ||
117 | static enum snd_bebob_clock_type saffirepro_26_clk_src_types[] = { | 111 | static enum snd_bebob_clock_type saffirepro_26_clk_src_types[] = { |
118 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 112 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
119 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ | 113 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ |
@@ -207,9 +201,6 @@ end: | |||
207 | } | 201 | } |
208 | 202 | ||
209 | struct snd_bebob_spec saffire_le_spec; | 203 | struct snd_bebob_spec saffire_le_spec; |
210 | static const char *const saffire_both_clk_src_labels[] = { | ||
211 | SND_BEBOB_CLOCK_INTERNAL, "S/PDIF" | ||
212 | }; | ||
213 | static enum snd_bebob_clock_type saffire_both_clk_src_types[] = { | 204 | static enum snd_bebob_clock_type saffire_both_clk_src_types[] = { |
214 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 205 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
215 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, | 206 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, |
@@ -276,7 +267,6 @@ static struct snd_bebob_rate_spec saffirepro_both_rate_spec = { | |||
276 | /* Saffire Pro 26 I/O */ | 267 | /* Saffire Pro 26 I/O */ |
277 | static struct snd_bebob_clock_spec saffirepro_26_clk_spec = { | 268 | static struct snd_bebob_clock_spec saffirepro_26_clk_spec = { |
278 | .num = ARRAY_SIZE(saffirepro_26_clk_src_types), | 269 | .num = ARRAY_SIZE(saffirepro_26_clk_src_types), |
279 | .labels = saffirepro_26_clk_src_labels, | ||
280 | .types = saffirepro_26_clk_src_types, | 270 | .types = saffirepro_26_clk_src_types, |
281 | .get = &saffirepro_both_clk_src_get, | 271 | .get = &saffirepro_both_clk_src_get, |
282 | }; | 272 | }; |
@@ -288,7 +278,6 @@ struct snd_bebob_spec saffirepro_26_spec = { | |||
288 | /* Saffire Pro 10 I/O */ | 278 | /* Saffire Pro 10 I/O */ |
289 | static struct snd_bebob_clock_spec saffirepro_10_clk_spec = { | 279 | static struct snd_bebob_clock_spec saffirepro_10_clk_spec = { |
290 | .num = ARRAY_SIZE(saffirepro_10_clk_src_types), | 280 | .num = ARRAY_SIZE(saffirepro_10_clk_src_types), |
291 | .labels = saffirepro_10_clk_src_labels, | ||
292 | .types = saffirepro_10_clk_src_types, | 281 | .types = saffirepro_10_clk_src_types, |
293 | .get = &saffirepro_both_clk_src_get, | 282 | .get = &saffirepro_both_clk_src_get, |
294 | }; | 283 | }; |
@@ -304,7 +293,6 @@ static struct snd_bebob_rate_spec saffire_both_rate_spec = { | |||
304 | }; | 293 | }; |
305 | static struct snd_bebob_clock_spec saffire_both_clk_spec = { | 294 | static struct snd_bebob_clock_spec saffire_both_clk_spec = { |
306 | .num = ARRAY_SIZE(saffire_both_clk_src_types), | 295 | .num = ARRAY_SIZE(saffire_both_clk_src_types), |
307 | .labels = saffire_both_clk_src_labels, | ||
308 | .types = saffire_both_clk_src_types, | 296 | .types = saffire_both_clk_src_types, |
309 | .get = &saffire_both_clk_src_get, | 297 | .get = &saffire_both_clk_src_get, |
310 | }; | 298 | }; |
diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c index 7a43afcfa9bd..057495d54ab0 100644 --- a/sound/firewire/bebob/bebob_maudio.c +++ b/sound/firewire/bebob/bebob_maudio.c | |||
@@ -340,9 +340,6 @@ end: | |||
340 | } | 340 | } |
341 | 341 | ||
342 | /* Clock source control for special firmware */ | 342 | /* Clock source control for special firmware */ |
343 | static const char *const special_clk_labels[] = { | ||
344 | SND_BEBOB_CLOCK_INTERNAL " with Digital Mute", "Digital", | ||
345 | "Word Clock", SND_BEBOB_CLOCK_INTERNAL}; | ||
346 | static enum snd_bebob_clock_type special_clk_types[] = { | 343 | static enum snd_bebob_clock_type special_clk_types[] = { |
347 | SND_BEBOB_CLOCK_TYPE_INTERNAL, /* With digital mute */ | 344 | SND_BEBOB_CLOCK_TYPE_INTERNAL, /* With digital mute */ |
348 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* SPDIF/ADAT */ | 345 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* SPDIF/ADAT */ |
@@ -358,6 +355,12 @@ static int special_clk_get(struct snd_bebob *bebob, unsigned int *id) | |||
358 | static int special_clk_ctl_info(struct snd_kcontrol *kctl, | 355 | static int special_clk_ctl_info(struct snd_kcontrol *kctl, |
359 | struct snd_ctl_elem_info *einf) | 356 | struct snd_ctl_elem_info *einf) |
360 | { | 357 | { |
358 | static const char *const special_clk_labels[] = { | ||
359 | "Internal with Digital Mute", | ||
360 | "Digital", | ||
361 | "Word Clock", | ||
362 | "Internal" | ||
363 | }; | ||
361 | return snd_ctl_enum_info(einf, 1, ARRAY_SIZE(special_clk_types), | 364 | return snd_ctl_enum_info(einf, 1, ARRAY_SIZE(special_clk_types), |
362 | special_clk_labels); | 365 | special_clk_labels); |
363 | } | 366 | } |
@@ -715,7 +718,6 @@ static struct snd_bebob_rate_spec special_rate_spec = { | |||
715 | }; | 718 | }; |
716 | static struct snd_bebob_clock_spec special_clk_spec = { | 719 | static struct snd_bebob_clock_spec special_clk_spec = { |
717 | .num = ARRAY_SIZE(special_clk_types), | 720 | .num = ARRAY_SIZE(special_clk_types), |
718 | .labels = special_clk_labels, | ||
719 | .types = special_clk_types, | 721 | .types = special_clk_types, |
720 | .get = &special_clk_get, | 722 | .get = &special_clk_get, |
721 | }; | 723 | }; |
diff --git a/sound/firewire/bebob/bebob_terratec.c b/sound/firewire/bebob/bebob_terratec.c index 3b64d8db8e14..9242e33d2cf1 100644 --- a/sound/firewire/bebob/bebob_terratec.c +++ b/sound/firewire/bebob/bebob_terratec.c | |||
@@ -8,9 +8,6 @@ | |||
8 | 8 | ||
9 | #include "./bebob.h" | 9 | #include "./bebob.h" |
10 | 10 | ||
11 | static const char *const phase88_rack_clk_src_labels[] = { | ||
12 | SND_BEBOB_CLOCK_INTERNAL, "Digital In", "Word Clock" | ||
13 | }; | ||
14 | static enum snd_bebob_clock_type phase88_rack_clk_src_types[] = { | 11 | static enum snd_bebob_clock_type phase88_rack_clk_src_types[] = { |
15 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 12 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
16 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ | 13 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ |
@@ -39,9 +36,6 @@ end: | |||
39 | return err; | 36 | return err; |
40 | } | 37 | } |
41 | 38 | ||
42 | static const char *const phase24_series_clk_src_labels[] = { | ||
43 | SND_BEBOB_CLOCK_INTERNAL, "Digital In" | ||
44 | }; | ||
45 | static enum snd_bebob_clock_type phase24_series_clk_src_types[] = { | 39 | static enum snd_bebob_clock_type phase24_series_clk_src_types[] = { |
46 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 40 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
47 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ | 41 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ |
@@ -69,7 +63,6 @@ static struct snd_bebob_rate_spec phase_series_rate_spec = { | |||
69 | /* PHASE 88 Rack FW */ | 63 | /* PHASE 88 Rack FW */ |
70 | static struct snd_bebob_clock_spec phase88_rack_clk = { | 64 | static struct snd_bebob_clock_spec phase88_rack_clk = { |
71 | .num = ARRAY_SIZE(phase88_rack_clk_src_types), | 65 | .num = ARRAY_SIZE(phase88_rack_clk_src_types), |
72 | .labels = phase88_rack_clk_src_labels, | ||
73 | .types = phase88_rack_clk_src_types, | 66 | .types = phase88_rack_clk_src_types, |
74 | .get = &phase88_rack_clk_src_get, | 67 | .get = &phase88_rack_clk_src_get, |
75 | }; | 68 | }; |
@@ -82,7 +75,6 @@ struct snd_bebob_spec phase88_rack_spec = { | |||
82 | /* 'PHASE 24 FW' and 'PHASE X24 FW' */ | 75 | /* 'PHASE 24 FW' and 'PHASE X24 FW' */ |
83 | static struct snd_bebob_clock_spec phase24_series_clk = { | 76 | static struct snd_bebob_clock_spec phase24_series_clk = { |
84 | .num = ARRAY_SIZE(phase24_series_clk_src_types), | 77 | .num = ARRAY_SIZE(phase24_series_clk_src_types), |
85 | .labels = phase24_series_clk_src_labels, | ||
86 | .types = phase24_series_clk_src_types, | 78 | .types = phase24_series_clk_src_types, |
87 | .get = &phase24_series_clk_src_get, | 79 | .get = &phase24_series_clk_src_get, |
88 | }; | 80 | }; |
diff --git a/sound/firewire/bebob/bebob_yamaha.c b/sound/firewire/bebob/bebob_yamaha.c index 2f59512ad91e..58101702410b 100644 --- a/sound/firewire/bebob/bebob_yamaha.c +++ b/sound/firewire/bebob/bebob_yamaha.c | |||
@@ -28,7 +28,6 @@ | |||
28 | * reccomend users to close ffado-mixer at 192.0kHz if mixer is needless. | 28 | * reccomend users to close ffado-mixer at 192.0kHz if mixer is needless. |
29 | */ | 29 | */ |
30 | 30 | ||
31 | static const char *const clk_src_labels[] = {SND_BEBOB_CLOCK_INTERNAL, "SPDIF"}; | ||
32 | static enum snd_bebob_clock_type clk_src_types[] = { | 31 | static enum snd_bebob_clock_type clk_src_types[] = { |
33 | SND_BEBOB_CLOCK_TYPE_INTERNAL, | 32 | SND_BEBOB_CLOCK_TYPE_INTERNAL, |
34 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ | 33 | SND_BEBOB_CLOCK_TYPE_EXTERNAL, /* S/PDIF */ |
@@ -50,7 +49,6 @@ clk_src_get(struct snd_bebob *bebob, unsigned int *id) | |||
50 | static struct snd_bebob_clock_spec clock_spec = { | 49 | static struct snd_bebob_clock_spec clock_spec = { |
51 | .num = ARRAY_SIZE(clk_src_types), | 50 | .num = ARRAY_SIZE(clk_src_types), |
52 | .types = clk_src_types, | 51 | .types = clk_src_types, |
53 | .labels = clk_src_labels, | ||
54 | .get = &clk_src_get, | 52 | .get = &clk_src_get, |
55 | }; | 53 | }; |
56 | static struct snd_bebob_rate_spec rate_spec = { | 54 | static struct snd_bebob_rate_spec rate_spec = { |