aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>2015-11-03 16:19:02 -0500
committerSteven Rostedt <rostedt@goodmis.org>2015-11-03 16:19:02 -0500
commit54ed1444052467044e9e01334ac8123dd6345211 (patch)
treee435736db73b7c7fede3ffa953641aaa8c576615
parent919cd9799936843d0af4f0904a3e39e70294c4d8 (diff)
ring_buffer: Remove unneeded smp_wmb() before wakeup of reader benchmark
wake_up_process() has a memory barrier before doing anything, thus adding a memory barrier before calling it is redundant. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r--kernel/trace/ring_buffer_benchmark.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/trace/ring_buffer_benchmark.c b/kernel/trace/ring_buffer_benchmark.c
index 9e00fd178226..6df9a83e20d7 100644
--- a/kernel/trace/ring_buffer_benchmark.c
+++ b/kernel/trace/ring_buffer_benchmark.c
@@ -288,8 +288,6 @@ static void ring_buffer_producer(void)
288 /* the completions must be visible before the finish var */ 288 /* the completions must be visible before the finish var */
289 smp_wmb(); 289 smp_wmb();
290 reader_finish = 1; 290 reader_finish = 1;
291 /* finish var visible before waking up the consumer */
292 smp_wmb();
293 wake_up_process(consumer); 291 wake_up_process(consumer);
294 wait_for_completion(&read_done); 292 wait_for_completion(&read_done);
295 } 293 }