diff options
author | Rashika Kheria <rashika.kheria@gmail.com> | 2013-12-16 05:58:24 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-17 12:37:44 -0500 |
commit | 54af58363e43b557cf17374c12a825f5209ef464 (patch) | |
tree | 3e8cb26894358374c371bb87e3f42354c822d0fd | |
parent | c25a1ad7077ab9914bad1374df8b9cdb9bf5f0ad (diff) |
drivers: tty: Mark the functions as static in n_gsm.c
Marks the functions gsm_cleanup_mux(), gsm_activate_mux(),
gsm_free_mux(), gsm_alloc_mux() and gsm_change_mtu() as static in
n_gsm.c because they are not used outside this file.
Also, drop the EXPORT_SYMBOL_GPL for the above mentioned functions
because nothing else in the kernel calls them.
This eliminates the following warnings in n_gsm.c:
drivers/tty/n_gsm.c:2022:6: warning: no previous prototype for ‘gsm_cleanup_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2076:5: warning: no previous prototype for ‘gsm_activate_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2120:6: warning: no previous prototype for ‘gsm_free_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2156:17: warning: no previous prototype for ‘gsm_alloc_mux’ [-Wmissing-prototypes]
drivers/tty/n_gsm.c:2714:5: warning: no previous prototype for ‘gsm_change_mtu’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/tty/n_gsm.c | 14 |
1 files changed, 5 insertions, 9 deletions
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 679294b37653..b94737b54e3e 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c | |||
@@ -2020,7 +2020,7 @@ static void gsm_error(struct gsm_mux *gsm, | |||
2020 | * and then shut down each device hanging up the channels as we go. | 2020 | * and then shut down each device hanging up the channels as we go. |
2021 | */ | 2021 | */ |
2022 | 2022 | ||
2023 | void gsm_cleanup_mux(struct gsm_mux *gsm) | 2023 | static void gsm_cleanup_mux(struct gsm_mux *gsm) |
2024 | { | 2024 | { |
2025 | int i; | 2025 | int i; |
2026 | struct gsm_dlci *dlci = gsm->dlci[0]; | 2026 | struct gsm_dlci *dlci = gsm->dlci[0]; |
@@ -2065,7 +2065,6 @@ void gsm_cleanup_mux(struct gsm_mux *gsm) | |||
2065 | kfree(txq); | 2065 | kfree(txq); |
2066 | INIT_LIST_HEAD(&gsm->tx_list); | 2066 | INIT_LIST_HEAD(&gsm->tx_list); |
2067 | } | 2067 | } |
2068 | EXPORT_SYMBOL_GPL(gsm_cleanup_mux); | ||
2069 | 2068 | ||
2070 | /** | 2069 | /** |
2071 | * gsm_activate_mux - generic GSM setup | 2070 | * gsm_activate_mux - generic GSM setup |
@@ -2076,7 +2075,7 @@ EXPORT_SYMBOL_GPL(gsm_cleanup_mux); | |||
2076 | * finally kick off connecting to DLCI 0 on the modem. | 2075 | * finally kick off connecting to DLCI 0 on the modem. |
2077 | */ | 2076 | */ |
2078 | 2077 | ||
2079 | int gsm_activate_mux(struct gsm_mux *gsm) | 2078 | static int gsm_activate_mux(struct gsm_mux *gsm) |
2080 | { | 2079 | { |
2081 | struct gsm_dlci *dlci; | 2080 | struct gsm_dlci *dlci; |
2082 | int i = 0; | 2081 | int i = 0; |
@@ -2112,7 +2111,6 @@ int gsm_activate_mux(struct gsm_mux *gsm) | |||
2112 | gsm->dead = 0; /* Tty opens are now permissible */ | 2111 | gsm->dead = 0; /* Tty opens are now permissible */ |
2113 | return 0; | 2112 | return 0; |
2114 | } | 2113 | } |
2115 | EXPORT_SYMBOL_GPL(gsm_activate_mux); | ||
2116 | 2114 | ||
2117 | /** | 2115 | /** |
2118 | * gsm_free_mux - free up a mux | 2116 | * gsm_free_mux - free up a mux |
@@ -2120,13 +2118,12 @@ EXPORT_SYMBOL_GPL(gsm_activate_mux); | |||
2120 | * | 2118 | * |
2121 | * Dispose of allocated resources for a dead mux | 2119 | * Dispose of allocated resources for a dead mux |
2122 | */ | 2120 | */ |
2123 | void gsm_free_mux(struct gsm_mux *gsm) | 2121 | static void gsm_free_mux(struct gsm_mux *gsm) |
2124 | { | 2122 | { |
2125 | kfree(gsm->txframe); | 2123 | kfree(gsm->txframe); |
2126 | kfree(gsm->buf); | 2124 | kfree(gsm->buf); |
2127 | kfree(gsm); | 2125 | kfree(gsm); |
2128 | } | 2126 | } |
2129 | EXPORT_SYMBOL_GPL(gsm_free_mux); | ||
2130 | 2127 | ||
2131 | /** | 2128 | /** |
2132 | * gsm_free_muxr - free up a mux | 2129 | * gsm_free_muxr - free up a mux |
@@ -2156,7 +2153,7 @@ static inline void mux_put(struct gsm_mux *gsm) | |||
2156 | * Creates a new mux ready for activation. | 2153 | * Creates a new mux ready for activation. |
2157 | */ | 2154 | */ |
2158 | 2155 | ||
2159 | struct gsm_mux *gsm_alloc_mux(void) | 2156 | static struct gsm_mux *gsm_alloc_mux(void) |
2160 | { | 2157 | { |
2161 | struct gsm_mux *gsm = kzalloc(sizeof(struct gsm_mux), GFP_KERNEL); | 2158 | struct gsm_mux *gsm = kzalloc(sizeof(struct gsm_mux), GFP_KERNEL); |
2162 | if (gsm == NULL) | 2159 | if (gsm == NULL) |
@@ -2189,7 +2186,6 @@ struct gsm_mux *gsm_alloc_mux(void) | |||
2189 | 2186 | ||
2190 | return gsm; | 2187 | return gsm; |
2191 | } | 2188 | } |
2192 | EXPORT_SYMBOL_GPL(gsm_alloc_mux); | ||
2193 | 2189 | ||
2194 | /** | 2190 | /** |
2195 | * gsmld_output - write to link | 2191 | * gsmld_output - write to link |
@@ -2716,7 +2712,7 @@ static void gsm_mux_rx_netchar(struct gsm_dlci *dlci, | |||
2716 | return; | 2712 | return; |
2717 | } | 2713 | } |
2718 | 2714 | ||
2719 | int gsm_change_mtu(struct net_device *net, int new_mtu) | 2715 | static int gsm_change_mtu(struct net_device *net, int new_mtu) |
2720 | { | 2716 | { |
2721 | struct gsm_mux_net *mux_net = (struct gsm_mux_net *)netdev_priv(net); | 2717 | struct gsm_mux_net *mux_net = (struct gsm_mux_net *)netdev_priv(net); |
2722 | if ((new_mtu < 8) || (new_mtu > mux_net->dlci->gsm->mtu)) | 2718 | if ((new_mtu < 8) || (new_mtu > mux_net->dlci->gsm->mtu)) |