diff options
author | Jeff Mahoney <jeffm@suse.com> | 2017-06-22 16:35:04 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2017-06-23 03:40:24 -0400 |
commit | 54930dfeb46e978b447af0fb8ab4e181c1bf9d7a (patch) | |
tree | a806487d2847781850f772ec7edaeaea2148da5a | |
parent | fd3cfad374d452ebe0a2f87f37c2ceeea7e0d134 (diff) |
reiserfs: don't preallocate blocks for extended attributes
Most extended attributes will fit in a single block. More importantly,
we drop the reference to the inode while holding the transaction open
so the preallocated blocks aren't released. As a result, the inode
may be evicted before it's removed from the transaction's prealloc list
which can cause memory corruption.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r-- | fs/reiserfs/bitmap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/reiserfs/bitmap.c b/fs/reiserfs/bitmap.c index dc198bc64c61..a6f39fe2b664 100644 --- a/fs/reiserfs/bitmap.c +++ b/fs/reiserfs/bitmap.c | |||
@@ -1128,7 +1128,7 @@ static int determine_prealloc_size(reiserfs_blocknr_hint_t * hint) | |||
1128 | hint->prealloc_size = 0; | 1128 | hint->prealloc_size = 0; |
1129 | 1129 | ||
1130 | if (!hint->formatted_node && hint->preallocate) { | 1130 | if (!hint->formatted_node && hint->preallocate) { |
1131 | if (S_ISREG(hint->inode->i_mode) | 1131 | if (S_ISREG(hint->inode->i_mode) && !IS_PRIVATE(hint->inode) |
1132 | && hint->inode->i_size >= | 1132 | && hint->inode->i_size >= |
1133 | REISERFS_SB(hint->th->t_super)->s_alloc_options. | 1133 | REISERFS_SB(hint->th->t_super)->s_alloc_options. |
1134 | preallocmin * hint->inode->i_sb->s_blocksize) | 1134 | preallocmin * hint->inode->i_sb->s_blocksize) |