diff options
author | Ivan Vecera <cera@cera.cz> | 2018-01-19 14:23:50 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-01-22 16:22:42 -0500 |
commit | 52acf06451930eb4cefabd5ecea56e2d46c32f76 (patch) | |
tree | 3b073389be09f602e6ca1dde8d86163898ead9f8 | |
parent | ad23b750933ea7bf962678972a286c78a8fa36aa (diff) |
be2net: restore properly promisc mode after queues reconfiguration
The commit 622190669403 ("be2net: Request RSS capability of Rx interface
depending on number of Rx rings") modified be_update_queues() so the
IFACE (HW representation of the netdevice) is destroyed and then
re-created. This causes a regression because potential promiscuous mode
is not restored properly during be_open() because the driver thinks
that the HW has promiscuous mode already enabled.
Note that Lancer is not affected by this bug because RX-filter flags are
disabled during be_close() for this chipset.
Cc: Sathya Perla <sathya.perla@broadcom.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>
Fixes: 622190669403 ("be2net: Request RSS capability of Rx interface depending on number of Rx rings")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index c6e859a27ee6..e180657a02ef 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
@@ -4634,6 +4634,15 @@ int be_update_queues(struct be_adapter *adapter) | |||
4634 | 4634 | ||
4635 | be_schedule_worker(adapter); | 4635 | be_schedule_worker(adapter); |
4636 | 4636 | ||
4637 | /* | ||
4638 | * The IF was destroyed and re-created. We need to clear | ||
4639 | * all promiscuous flags valid for the destroyed IF. | ||
4640 | * Without this promisc mode is not restored during | ||
4641 | * be_open() because the driver thinks that it is | ||
4642 | * already enabled in HW. | ||
4643 | */ | ||
4644 | adapter->if_flags &= ~BE_IF_FLAGS_ALL_PROMISCUOUS; | ||
4645 | |||
4637 | if (netif_running(netdev)) | 4646 | if (netif_running(netdev)) |
4638 | status = be_open(netdev); | 4647 | status = be_open(netdev); |
4639 | 4648 | ||