aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZubin Mithra <zsm@chromium.org>2018-07-25 13:19:01 -0400
committerSteven Rostedt (VMware) <rostedt@goodmis.org>2018-07-31 11:32:44 -0400
commit5248ee85603067e62a228402afd2fb68f957746b (patch)
tree2f9c99ec03cf8189bf1323ed80f3e04f34189ea3
parentc3bc8fd637a9623f5c507bd18f9677effbddf584 (diff)
tracefs: Annotate tracefs_ops with __ro_after_init
tracefs_ops is initialized inside tracefs_create_instance_dir and not modified after. tracefs_create_instance_dir allows for initialization only once, and is called from create_trace_instances(marked __init), which is called from tracer_init_tracefs(marked __init). Also, mark tracefs_create_instance_dir as __init. Link: http://lkml.kernel.org/r/20180725171901.4468-1-zsm@chromium.org Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Zubin Mithra <zsm@chromium.org> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-rw-r--r--fs/tracefs/inode.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index bea8ad876bf9..7098c49f3693 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -53,7 +53,7 @@ static const struct file_operations tracefs_file_operations = {
53static struct tracefs_dir_ops { 53static struct tracefs_dir_ops {
54 int (*mkdir)(const char *name); 54 int (*mkdir)(const char *name);
55 int (*rmdir)(const char *name); 55 int (*rmdir)(const char *name);
56} tracefs_ops; 56} tracefs_ops __ro_after_init;
57 57
58static char *get_dname(struct dentry *dentry) 58static char *get_dname(struct dentry *dentry)
59{ 59{
@@ -478,7 +478,8 @@ struct dentry *tracefs_create_dir(const char *name, struct dentry *parent)
478 * 478 *
479 * Returns the dentry of the instances directory. 479 * Returns the dentry of the instances directory.
480 */ 480 */
481struct dentry *tracefs_create_instance_dir(const char *name, struct dentry *parent, 481__init struct dentry *tracefs_create_instance_dir(const char *name,
482 struct dentry *parent,
482 int (*mkdir)(const char *name), 483 int (*mkdir)(const char *name),
483 int (*rmdir)(const char *name)) 484 int (*rmdir)(const char *name))
484{ 485{