diff options
author | Dave Airlie <airlied@redhat.com> | 2016-11-16 18:44:52 -0500 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2016-11-16 18:44:52 -0500 |
commit | 51a4c38a5511c0027c54d330f7dd2239f6c95b82 (patch) | |
tree | 042e58dea131b78fa59adb5192001c0e60fda05c | |
parent | 94ea29b116652b8b08934493fae68a6b83e2bc45 (diff) | |
parent | 0d2200794f0a2c1ebb3b6613842914d8ce4b67f9 (diff) |
Merge branch 'mediatek-drm-fixes-2016-11-11' of https://github.com/ckhu-mediatek/linux.git-tags into drm-fixes
This branch include one patch to fix a typo, two patches to disable
vblank interrupt, and three patches to support HDMI 4K resolution.
* 'mediatek-drm-fixes-2016-11-11' of https://github.com/ckhu-mediatek/linux.git-tags:
drm/mediatek: modify the factor to make the pll_rate set in the 1G-2G range
drm/mediatek: enhance the HDMI driving current
drm/mediatek: do mtk_hdmi_send_infoframe after HDMI clock enable
drm/mediatek: clear IRQ status before enable OVL interrupt
drm/mediatek: set vblank_disable_allowed to true
drm/mediatek: fix a typo of OD_CFG to OD_RELAYMODE
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_dpi.c | 9 | ||||
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_hdmi.c | 17 | ||||
-rw-r--r-- | drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 42 |
6 files changed, 51 insertions, 21 deletions
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 019b7ca392d7..f75c5b5a536c 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c | |||
@@ -80,6 +80,7 @@ static void mtk_ovl_enable_vblank(struct mtk_ddp_comp *comp, | |||
80 | ddp_comp); | 80 | ddp_comp); |
81 | 81 | ||
82 | priv->crtc = crtc; | 82 | priv->crtc = crtc; |
83 | writel(0x0, comp->regs + DISP_REG_OVL_INTSTA); | ||
83 | writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN); | 84 | writel_relaxed(OVL_FME_CPL_INT, comp->regs + DISP_REG_OVL_INTEN); |
84 | } | 85 | } |
85 | 86 | ||
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 0186e500d2a5..90fb831ef031 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c | |||
@@ -432,11 +432,16 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi, | |||
432 | unsigned long pll_rate; | 432 | unsigned long pll_rate; |
433 | unsigned int factor; | 433 | unsigned int factor; |
434 | 434 | ||
435 | /* let pll_rate can fix the valid range of tvdpll (1G~2GHz) */ | ||
435 | pix_rate = 1000UL * mode->clock; | 436 | pix_rate = 1000UL * mode->clock; |
436 | if (mode->clock <= 74000) | 437 | if (mode->clock <= 27000) |
438 | factor = 16 * 3; | ||
439 | else if (mode->clock <= 84000) | ||
437 | factor = 8 * 3; | 440 | factor = 8 * 3; |
438 | else | 441 | else if (mode->clock <= 167000) |
439 | factor = 4 * 3; | 442 | factor = 4 * 3; |
443 | else | ||
444 | factor = 2 * 3; | ||
440 | pll_rate = pix_rate * factor; | 445 | pll_rate = pix_rate * factor; |
441 | 446 | ||
442 | dev_dbg(dpi->dev, "Want PLL %lu Hz, pixel clock %lu Hz\n", | 447 | dev_dbg(dpi->dev, "Want PLL %lu Hz, pixel clock %lu Hz\n", |
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index df33b3ca6ffd..aa5f20fabd10 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | |||
@@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w, | |||
123 | unsigned int bpc) | 123 | unsigned int bpc) |
124 | { | 124 | { |
125 | writel(w << 16 | h, comp->regs + DISP_OD_SIZE); | 125 | writel(w << 16 | h, comp->regs + DISP_OD_SIZE); |
126 | writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE); | 126 | writel(OD_RELAYMODE, comp->regs + OD_CFG); |
127 | mtk_dither_set(comp, bpc, DISP_OD_CFG); | 127 | mtk_dither_set(comp, bpc, DISP_OD_CFG); |
128 | } | 128 | } |
129 | 129 | ||
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index cf83f6507ec8..0b2ae47eb52c 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c | |||
@@ -217,6 +217,7 @@ static int mtk_drm_kms_init(struct drm_device *drm) | |||
217 | if (ret < 0) | 217 | if (ret < 0) |
218 | goto err_component_unbind; | 218 | goto err_component_unbind; |
219 | 219 | ||
220 | drm->vblank_disable_allowed = true; | ||
220 | drm_kms_helper_poll_init(drm); | 221 | drm_kms_helper_poll_init(drm); |
221 | drm_mode_config_reset(drm); | 222 | drm_mode_config_reset(drm); |
222 | 223 | ||
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index 71227deef21b..0e8c4d9af340 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c | |||
@@ -1133,12 +1133,6 @@ static int mtk_hdmi_output_set_display_mode(struct mtk_hdmi *hdmi, | |||
1133 | phy_power_on(hdmi->phy); | 1133 | phy_power_on(hdmi->phy); |
1134 | mtk_hdmi_aud_output_config(hdmi, mode); | 1134 | mtk_hdmi_aud_output_config(hdmi, mode); |
1135 | 1135 | ||
1136 | mtk_hdmi_setup_audio_infoframe(hdmi); | ||
1137 | mtk_hdmi_setup_avi_infoframe(hdmi, mode); | ||
1138 | mtk_hdmi_setup_spd_infoframe(hdmi, "mediatek", "On-chip HDMI"); | ||
1139 | if (mode->flags & DRM_MODE_FLAG_3D_MASK) | ||
1140 | mtk_hdmi_setup_vendor_specific_infoframe(hdmi, mode); | ||
1141 | |||
1142 | mtk_hdmi_hw_vid_black(hdmi, false); | 1136 | mtk_hdmi_hw_vid_black(hdmi, false); |
1143 | mtk_hdmi_hw_aud_unmute(hdmi); | 1137 | mtk_hdmi_hw_aud_unmute(hdmi); |
1144 | mtk_hdmi_hw_send_av_unmute(hdmi); | 1138 | mtk_hdmi_hw_send_av_unmute(hdmi); |
@@ -1401,6 +1395,16 @@ static void mtk_hdmi_bridge_pre_enable(struct drm_bridge *bridge) | |||
1401 | hdmi->powered = true; | 1395 | hdmi->powered = true; |
1402 | } | 1396 | } |
1403 | 1397 | ||
1398 | static void mtk_hdmi_send_infoframe(struct mtk_hdmi *hdmi, | ||
1399 | struct drm_display_mode *mode) | ||
1400 | { | ||
1401 | mtk_hdmi_setup_audio_infoframe(hdmi); | ||
1402 | mtk_hdmi_setup_avi_infoframe(hdmi, mode); | ||
1403 | mtk_hdmi_setup_spd_infoframe(hdmi, "mediatek", "On-chip HDMI"); | ||
1404 | if (mode->flags & DRM_MODE_FLAG_3D_MASK) | ||
1405 | mtk_hdmi_setup_vendor_specific_infoframe(hdmi, mode); | ||
1406 | } | ||
1407 | |||
1404 | static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) | 1408 | static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) |
1405 | { | 1409 | { |
1406 | struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge); | 1410 | struct mtk_hdmi *hdmi = hdmi_ctx_from_bridge(bridge); |
@@ -1409,6 +1413,7 @@ static void mtk_hdmi_bridge_enable(struct drm_bridge *bridge) | |||
1409 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PLL]); | 1413 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PLL]); |
1410 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PIXEL]); | 1414 | clk_prepare_enable(hdmi->clk[MTK_HDMI_CLK_HDMI_PIXEL]); |
1411 | phy_power_on(hdmi->phy); | 1415 | phy_power_on(hdmi->phy); |
1416 | mtk_hdmi_send_infoframe(hdmi, &hdmi->mode); | ||
1412 | 1417 | ||
1413 | hdmi->enabled = true; | 1418 | hdmi->enabled = true; |
1414 | } | 1419 | } |
diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c index 8a24754b440f..51cb9cfb6646 100644 --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | |||
@@ -265,6 +265,9 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
265 | struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); | 265 | struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw); |
266 | unsigned int pre_div; | 266 | unsigned int pre_div; |
267 | unsigned int div; | 267 | unsigned int div; |
268 | unsigned int pre_ibias; | ||
269 | unsigned int hdmi_ibias; | ||
270 | unsigned int imp_en; | ||
268 | 271 | ||
269 | dev_dbg(hdmi_phy->dev, "%s: %lu Hz, parent: %lu Hz\n", __func__, | 272 | dev_dbg(hdmi_phy->dev, "%s: %lu Hz, parent: %lu Hz\n", __func__, |
270 | rate, parent_rate); | 273 | rate, parent_rate); |
@@ -298,18 +301,31 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
298 | (0x1 << PLL_BR_SHIFT), | 301 | (0x1 << PLL_BR_SHIFT), |
299 | RG_HDMITX_PLL_BP | RG_HDMITX_PLL_BC | | 302 | RG_HDMITX_PLL_BP | RG_HDMITX_PLL_BC | |
300 | RG_HDMITX_PLL_BR); | 303 | RG_HDMITX_PLL_BR); |
301 | mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON3, RG_HDMITX_PRD_IMP_EN); | 304 | if (rate < 165000000) { |
305 | mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON3, | ||
306 | RG_HDMITX_PRD_IMP_EN); | ||
307 | pre_ibias = 0x3; | ||
308 | imp_en = 0x0; | ||
309 | hdmi_ibias = hdmi_phy->ibias; | ||
310 | } else { | ||
311 | mtk_hdmi_phy_set_bits(hdmi_phy, HDMI_CON3, | ||
312 | RG_HDMITX_PRD_IMP_EN); | ||
313 | pre_ibias = 0x6; | ||
314 | imp_en = 0xf; | ||
315 | hdmi_ibias = hdmi_phy->ibias_up; | ||
316 | } | ||
302 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON4, | 317 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON4, |
303 | (0x3 << PRD_IBIAS_CLK_SHIFT) | | 318 | (pre_ibias << PRD_IBIAS_CLK_SHIFT) | |
304 | (0x3 << PRD_IBIAS_D2_SHIFT) | | 319 | (pre_ibias << PRD_IBIAS_D2_SHIFT) | |
305 | (0x3 << PRD_IBIAS_D1_SHIFT) | | 320 | (pre_ibias << PRD_IBIAS_D1_SHIFT) | |
306 | (0x3 << PRD_IBIAS_D0_SHIFT), | 321 | (pre_ibias << PRD_IBIAS_D0_SHIFT), |
307 | RG_HDMITX_PRD_IBIAS_CLK | | 322 | RG_HDMITX_PRD_IBIAS_CLK | |
308 | RG_HDMITX_PRD_IBIAS_D2 | | 323 | RG_HDMITX_PRD_IBIAS_D2 | |
309 | RG_HDMITX_PRD_IBIAS_D1 | | 324 | RG_HDMITX_PRD_IBIAS_D1 | |
310 | RG_HDMITX_PRD_IBIAS_D0); | 325 | RG_HDMITX_PRD_IBIAS_D0); |
311 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON3, | 326 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON3, |
312 | (0x0 << DRV_IMP_EN_SHIFT), RG_HDMITX_DRV_IMP_EN); | 327 | (imp_en << DRV_IMP_EN_SHIFT), |
328 | RG_HDMITX_DRV_IMP_EN); | ||
313 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON6, | 329 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON6, |
314 | (hdmi_phy->drv_imp_clk << DRV_IMP_CLK_SHIFT) | | 330 | (hdmi_phy->drv_imp_clk << DRV_IMP_CLK_SHIFT) | |
315 | (hdmi_phy->drv_imp_d2 << DRV_IMP_D2_SHIFT) | | 331 | (hdmi_phy->drv_imp_d2 << DRV_IMP_D2_SHIFT) | |
@@ -318,12 +334,14 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, | |||
318 | RG_HDMITX_DRV_IMP_CLK | RG_HDMITX_DRV_IMP_D2 | | 334 | RG_HDMITX_DRV_IMP_CLK | RG_HDMITX_DRV_IMP_D2 | |
319 | RG_HDMITX_DRV_IMP_D1 | RG_HDMITX_DRV_IMP_D0); | 335 | RG_HDMITX_DRV_IMP_D1 | RG_HDMITX_DRV_IMP_D0); |
320 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON5, | 336 | mtk_hdmi_phy_mask(hdmi_phy, HDMI_CON5, |
321 | (hdmi_phy->ibias << DRV_IBIAS_CLK_SHIFT) | | 337 | (hdmi_ibias << DRV_IBIAS_CLK_SHIFT) | |
322 | (hdmi_phy->ibias << DRV_IBIAS_D2_SHIFT) | | 338 | (hdmi_ibias << DRV_IBIAS_D2_SHIFT) | |
323 | (hdmi_phy->ibias << DRV_IBIAS_D1_SHIFT) | | 339 | (hdmi_ibias << DRV_IBIAS_D1_SHIFT) | |
324 | (hdmi_phy->ibias << DRV_IBIAS_D0_SHIFT), | 340 | (hdmi_ibias << DRV_IBIAS_D0_SHIFT), |
325 | RG_HDMITX_DRV_IBIAS_CLK | RG_HDMITX_DRV_IBIAS_D2 | | 341 | RG_HDMITX_DRV_IBIAS_CLK | |
326 | RG_HDMITX_DRV_IBIAS_D1 | RG_HDMITX_DRV_IBIAS_D0); | 342 | RG_HDMITX_DRV_IBIAS_D2 | |
343 | RG_HDMITX_DRV_IBIAS_D1 | | ||
344 | RG_HDMITX_DRV_IBIAS_D0); | ||
327 | return 0; | 345 | return 0; |
328 | } | 346 | } |
329 | 347 | ||