diff options
author | Chengguang Xu <cgxu519@gmx.com> | 2018-06-13 00:05:13 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-10-18 02:04:59 -0400 |
commit | 515f1867addaba49c1c6ac73abfaffbc192c1db4 (patch) | |
tree | fbddee5d65ec3b1156b6e0343bfb4d164593b71f | |
parent | 55338ac2a9839557516b00661e6a05daf996fda0 (diff) |
fs/exofs: fix potential memory leak in mount option parsing
There are some cases can cause memory leak when parsing
option 'osdname'.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r-- | fs/exofs/super.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/exofs/super.c b/fs/exofs/super.c index 41cf2fbee50d..7d61e3fa378c 100644 --- a/fs/exofs/super.c +++ b/fs/exofs/super.c | |||
@@ -101,6 +101,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts) | |||
101 | token = match_token(p, tokens, args); | 101 | token = match_token(p, tokens, args); |
102 | switch (token) { | 102 | switch (token) { |
103 | case Opt_name: | 103 | case Opt_name: |
104 | kfree(opts->dev_name); | ||
104 | opts->dev_name = match_strdup(&args[0]); | 105 | opts->dev_name = match_strdup(&args[0]); |
105 | if (unlikely(!opts->dev_name)) { | 106 | if (unlikely(!opts->dev_name)) { |
106 | EXOFS_ERR("Error allocating dev_name"); | 107 | EXOFS_ERR("Error allocating dev_name"); |
@@ -866,8 +867,10 @@ static struct dentry *exofs_mount(struct file_system_type *type, | |||
866 | int ret; | 867 | int ret; |
867 | 868 | ||
868 | ret = parse_options(data, &opts); | 869 | ret = parse_options(data, &opts); |
869 | if (ret) | 870 | if (ret) { |
871 | kfree(opts.dev_name); | ||
870 | return ERR_PTR(ret); | 872 | return ERR_PTR(ret); |
873 | } | ||
871 | 874 | ||
872 | if (!opts.dev_name) | 875 | if (!opts.dev_name) |
873 | opts.dev_name = dev_name; | 876 | opts.dev_name = dev_name; |