aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2017-04-15 14:55:51 -0400
committerJens Axboe <axboe@fb.com>2017-04-16 12:06:34 -0400
commit503ec94eca4f49c0a18d67bb60445fe998a601ae (patch)
treed3a6a9678a54352ec12c22f35f9625f3b5a87fb8
parenta4bd217b432685d6a177c28a2af187f041c473b7 (diff)
lightnvm: pblk-gc: fix an error pointer dereference in init
These labels are reversed so we could end up dereferencing an error pointer or leaking. Fixes: 7f347ba6bb3a ("lightnvm: physical block device (pblk) target") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Matias Bjørling <matias@cnexlabs.com> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--drivers/lightnvm/pblk-gc.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
index 9b147cfd8a41..f173fd4ea947 100644
--- a/drivers/lightnvm/pblk-gc.c
+++ b/drivers/lightnvm/pblk-gc.c
@@ -527,10 +527,10 @@ int pblk_gc_init(struct pblk *pblk)
527 527
528 return 0; 528 return 0;
529 529
530fail_free_main_kthread:
531 kthread_stop(gc->gc_ts);
532fail_free_writer_kthread: 530fail_free_writer_kthread:
533 kthread_stop(gc->gc_writer_ts); 531 kthread_stop(gc->gc_writer_ts);
532fail_free_main_kthread:
533 kthread_stop(gc->gc_ts);
534 534
535 return ret; 535 return ret;
536} 536}