diff options
author | Nikolay Borisov <nborisov@suse.com> | 2018-07-20 12:37:51 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2018-08-06 07:12:57 -0400 |
commit | 4f5ad7bd6315528ed50a11d53c66854a5d16425b (patch) | |
tree | 286a20070d43f4c1a698ad7b0c4ebde76a2d226c | |
parent | d6507cf1e2dfa4f6888cd90e4c9a307f7ac9b383 (diff) |
btrfs: Remove fs_info from btrfs_destroy_dev_replace_tgtdev
This function is always passed a well-formed tgtdevice so the fs_info
can be referenced from there.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
-rw-r--r-- | fs/btrfs/dev-replace.c | 6 | ||||
-rw-r--r-- | fs/btrfs/volumes.c | 5 | ||||
-rw-r--r-- | fs/btrfs/volumes.h | 3 |
3 files changed, 6 insertions, 8 deletions
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c index dd17a4d7bea2..5a72f9933e58 100644 --- a/fs/btrfs/dev-replace.c +++ b/fs/btrfs/dev-replace.c | |||
@@ -506,7 +506,7 @@ leave: | |||
506 | dev_replace->srcdev = NULL; | 506 | dev_replace->srcdev = NULL; |
507 | dev_replace->tgtdev = NULL; | 507 | dev_replace->tgtdev = NULL; |
508 | btrfs_dev_replace_write_unlock(dev_replace); | 508 | btrfs_dev_replace_write_unlock(dev_replace); |
509 | btrfs_destroy_dev_replace_tgtdev(fs_info, tgt_device); | 509 | btrfs_destroy_dev_replace_tgtdev(tgt_device); |
510 | return ret; | 510 | return ret; |
511 | } | 511 | } |
512 | 512 | ||
@@ -632,7 +632,7 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info, | |||
632 | mutex_unlock(&fs_info->fs_devices->device_list_mutex); | 632 | mutex_unlock(&fs_info->fs_devices->device_list_mutex); |
633 | btrfs_rm_dev_replace_blocked(fs_info); | 633 | btrfs_rm_dev_replace_blocked(fs_info); |
634 | if (tgt_device) | 634 | if (tgt_device) |
635 | btrfs_destroy_dev_replace_tgtdev(fs_info, tgt_device); | 635 | btrfs_destroy_dev_replace_tgtdev(tgt_device); |
636 | btrfs_rm_dev_replace_unblocked(fs_info); | 636 | btrfs_rm_dev_replace_unblocked(fs_info); |
637 | mutex_unlock(&dev_replace->lock_finishing_cancel_unmount); | 637 | mutex_unlock(&dev_replace->lock_finishing_cancel_unmount); |
638 | 638 | ||
@@ -821,7 +821,7 @@ int btrfs_dev_replace_cancel(struct btrfs_fs_info *fs_info) | |||
821 | btrfs_dev_name(tgt_device)); | 821 | btrfs_dev_name(tgt_device)); |
822 | 822 | ||
823 | if (tgt_device) | 823 | if (tgt_device) |
824 | btrfs_destroy_dev_replace_tgtdev(fs_info, tgt_device); | 824 | btrfs_destroy_dev_replace_tgtdev(tgt_device); |
825 | 825 | ||
826 | leave: | 826 | leave: |
827 | mutex_unlock(&dev_replace->lock_finishing_cancel_unmount); | 827 | mutex_unlock(&dev_replace->lock_finishing_cancel_unmount); |
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 9cd15964ab6f..45d7c37050ce 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c | |||
@@ -2063,10 +2063,9 @@ void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info, | |||
2063 | } | 2063 | } |
2064 | } | 2064 | } |
2065 | 2065 | ||
2066 | void btrfs_destroy_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, | 2066 | void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev) |
2067 | struct btrfs_device *tgtdev) | ||
2068 | { | 2067 | { |
2069 | struct btrfs_fs_devices *fs_devices = fs_info->fs_devices; | 2068 | struct btrfs_fs_devices *fs_devices = tgtdev->fs_info->fs_devices; |
2070 | 2069 | ||
2071 | WARN_ON(!tgtdev); | 2070 | WARN_ON(!tgtdev); |
2072 | mutex_lock(&fs_devices->device_list_mutex); | 2071 | mutex_lock(&fs_devices->device_list_mutex); |
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h index 1bcf0f34e8dc..69a028058c43 100644 --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h | |||
@@ -455,8 +455,7 @@ int btrfs_run_dev_stats(struct btrfs_trans_handle *trans, | |||
455 | void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev); | 455 | void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev); |
456 | void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info, | 456 | void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info, |
457 | struct btrfs_device *srcdev); | 457 | struct btrfs_device *srcdev); |
458 | void btrfs_destroy_dev_replace_tgtdev(struct btrfs_fs_info *fs_info, | 458 | void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev); |
459 | struct btrfs_device *tgtdev); | ||
460 | void btrfs_scratch_superblocks(struct block_device *bdev, const char *device_path); | 459 | void btrfs_scratch_superblocks(struct block_device *bdev, const char *device_path); |
461 | int btrfs_is_parity_mirror(struct btrfs_fs_info *fs_info, | 460 | int btrfs_is_parity_mirror(struct btrfs_fs_info *fs_info, |
462 | u64 logical, u64 len); | 461 | u64 logical, u64 len); |