diff options
author | Wolfram Sang <wsa@the-dreams.de> | 2016-04-09 02:32:37 -0400 |
---|---|---|
committer | Wolfram Sang <wsa@the-dreams.de> | 2016-04-09 02:32:37 -0400 |
commit | 4ececb7d173f17c60c00e704a0e4e51cdf788e04 (patch) | |
tree | 2e045896e94632621f8107db1f6bd639754ae0f4 | |
parent | 34cf2acdafaa31a13821e45de5ee896adcd307b1 (diff) |
Revert "i2c: jz4780: prevent potential division by zero"
This reverts commit 34cf2acdafaa31a13821e45de5ee896adcd307b1. 'ret' is
not set when bailing out. Also, there is a better place to check for 0.
Reported-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
-rw-r--r-- | drivers/i2c/busses/i2c-jz4780.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c index 597408fc6834..f325663c27c5 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c | |||
@@ -770,7 +770,7 @@ static int jz4780_i2c_probe(struct platform_device *pdev) | |||
770 | 770 | ||
771 | ret = of_property_read_u32(pdev->dev.of_node, "clock-frequency", | 771 | ret = of_property_read_u32(pdev->dev.of_node, "clock-frequency", |
772 | &clk_freq); | 772 | &clk_freq); |
773 | if (ret || clk_freq == 0) { | 773 | if (ret) { |
774 | dev_err(&pdev->dev, "clock-frequency not specified in DT"); | 774 | dev_err(&pdev->dev, "clock-frequency not specified in DT"); |
775 | goto err; | 775 | goto err; |
776 | } | 776 | } |