aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChao Yu <chao2.yu@samsung.com>2015-08-24 05:36:25 -0400
committerJaegeuk Kim <jaegeuk@kernel.org>2015-08-24 12:38:20 -0400
commit4ec17d688d74b6b7cb10043c57ff4818cde2b0ca (patch)
tree5614139dca4e67d4c1d2d1ff7b65dff2369734e1
parent6a6788576dac56135bf98ad974a038b0afb1a499 (diff)
f2fs: avoid unneeded initializing when converting inline dentry
When converting inline dentry, we will zero out target dentry page before duplicating data of inline dentry into target page, it become overhead since inline dentry size is not small. So this patch tries to remove unneeded initializing in the space of target dentry page. Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
-rw-r--r--fs/f2fs/inline.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 79d18d5c1fae..3d143be42895 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -384,13 +384,21 @@ static int f2fs_convert_inline_dir(struct inode *dir, struct page *ipage,
384 goto out; 384 goto out;
385 385
386 f2fs_wait_on_page_writeback(page, DATA); 386 f2fs_wait_on_page_writeback(page, DATA);
387 zero_user_segment(page, 0, PAGE_CACHE_SIZE); 387 zero_user_segment(page, MAX_INLINE_DATA, PAGE_CACHE_SIZE);
388 388
389 dentry_blk = kmap_atomic(page); 389 dentry_blk = kmap_atomic(page);
390 390
391 /* copy data from inline dentry block to new dentry block */ 391 /* copy data from inline dentry block to new dentry block */
392 memcpy(dentry_blk->dentry_bitmap, inline_dentry->dentry_bitmap, 392 memcpy(dentry_blk->dentry_bitmap, inline_dentry->dentry_bitmap,
393 INLINE_DENTRY_BITMAP_SIZE); 393 INLINE_DENTRY_BITMAP_SIZE);
394 memset(dentry_blk->dentry_bitmap + INLINE_DENTRY_BITMAP_SIZE, 0,
395 SIZE_OF_DENTRY_BITMAP - INLINE_DENTRY_BITMAP_SIZE);
396 /*
397 * we do not need to zero out remainder part of dentry and filename
398 * field, since we have used bitmap for marking the usage status of
399 * them, besides, we can also ignore copying/zeroing reserved space
400 * of dentry block, because them haven't been used so far.
401 */
394 memcpy(dentry_blk->dentry, inline_dentry->dentry, 402 memcpy(dentry_blk->dentry, inline_dentry->dentry,
395 sizeof(struct f2fs_dir_entry) * NR_INLINE_DENTRY); 403 sizeof(struct f2fs_dir_entry) * NR_INLINE_DENTRY);
396 memcpy(dentry_blk->filename, inline_dentry->filename, 404 memcpy(dentry_blk->filename, inline_dentry->filename,