aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>2017-05-11 18:33:23 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2017-06-08 21:52:40 -0400
commit4e4bea7427062ec15df7084f97728e2a44d912e3 (patch)
tree8ac0858e9d8f945cca18d4fefaef8ae11b74aa46
parentd2b1654f91f9e928011fbea7138854ee2044f470 (diff)
rcu: Remove typecheck() from RCU locking wrapper functions
Because raw_spin_lock_irqsave() and raw_spin_unlock_irqrestore() both do typecheck() on their flags argument, there is no point in duplicating this check in raw_spin_lock_irqsave_rcu_node() and raw_spin_unlock_irqrestore_rcu_node(). This commit therefore saves a few lines by removing this duplicated check. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r--kernel/rcu/rcu.h12
1 files changed, 4 insertions, 8 deletions
diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h
index 2a75beb883c8..bc55b5716c37 100644
--- a/kernel/rcu/rcu.h
+++ b/kernel/rcu/rcu.h
@@ -334,18 +334,14 @@ do { \
334#define raw_spin_unlock_irq_rcu_node(p) \ 334#define raw_spin_unlock_irq_rcu_node(p) \
335 raw_spin_unlock_irq(&ACCESS_PRIVATE(p, lock)) 335 raw_spin_unlock_irq(&ACCESS_PRIVATE(p, lock))
336 336
337#define raw_spin_lock_irqsave_rcu_node(rnp, flags) \ 337#define raw_spin_lock_irqsave_rcu_node(p, flags) \
338do { \ 338do { \
339 typecheck(unsigned long, flags); \ 339 raw_spin_lock_irqsave(&ACCESS_PRIVATE(p, lock), flags); \
340 raw_spin_lock_irqsave(&ACCESS_PRIVATE(rnp, lock), flags); \
341 smp_mb__after_unlock_lock(); \ 340 smp_mb__after_unlock_lock(); \
342} while (0) 341} while (0)
343 342
344#define raw_spin_unlock_irqrestore_rcu_node(rnp, flags) \ 343#define raw_spin_unlock_irqrestore_rcu_node(p, flags) \
345do { \ 344 raw_spin_unlock_irqrestore(&ACCESS_PRIVATE(p, lock), flags) \
346 typecheck(unsigned long, flags); \
347 raw_spin_unlock_irqrestore(&ACCESS_PRIVATE(rnp, lock), flags); \
348} while (0)
349 345
350#define raw_spin_trylock_rcu_node(p) \ 346#define raw_spin_trylock_rcu_node(p) \
351({ \ 347({ \