bcache: fix a leak in bch_cached_dev_run()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Tested-by: Joshua Schmid <jschmid@suse.com>
Tested-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: Kent Overstreet <kmo@daterainc.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@fb.com>

1 files changed, 4 insertions, 1 deletions

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 383f06028a0a..43e911e4e8d0 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -849,8 +849,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
         buf[SB_LABEL_SIZE] = '\0';
         env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);
 
-        if (atomic_xchg(&dc->running, 1))
+        if (atomic_xchg(&dc->running, 1)) {
+                kfree(env[1]);
+                kfree(env[2]);
                 return;
+        }
 
         if (!d->c &&
             BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {