diff options
author | Juri Lelli <juri.lelli@arm.com> | 2015-03-31 04:53:36 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2015-04-02 11:42:56 -0400 |
commit | 4cd57f97135840f637431c92380c8da3edbe44ed (patch) | |
tree | 3978d002c4b4faf47990a6de7a53af7345b86253 | |
parent | 07c54f7a7ff77bb47bae26e566969e9c4b6fb0c6 (diff) |
sched/deadline: Always enqueue on previous rq when dl_task_timer() fires
dl_task_timer() may fire on a different rq from where a task was removed
after throttling. Since the call path is:
dl_task_timer() ->
enqueue_task_dl() ->
enqueue_dl_entity() ->
replenish_dl_entity()
and replenish_dl_entity() uses dl_se's rq, we can't use current's rq
in dl_task_timer(), but we need to lock the task's previous one.
Tested-by: Wanpeng Li <wanpeng.li@linux.intel.com>
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Kirill Tkhai <ktkhai@parallels.com>
Cc: Juri Lelli <juri.lelli@gmail.com>
Fixes: 3960c8c0c789 ("sched: Make dl_task_time() use task_rq_lock()")
Link: http://lkml.kernel.org/r/1427792017-7356-1-git-send-email-juri.lelli@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | kernel/sched/deadline.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 5e2f99bd5ce0..9d3ad6433d88 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c | |||
@@ -514,7 +514,7 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer) | |||
514 | unsigned long flags; | 514 | unsigned long flags; |
515 | struct rq *rq; | 515 | struct rq *rq; |
516 | 516 | ||
517 | rq = task_rq_lock(current, &flags); | 517 | rq = task_rq_lock(p, &flags); |
518 | 518 | ||
519 | /* | 519 | /* |
520 | * We need to take care of several possible races here: | 520 | * We need to take care of several possible races here: |
@@ -569,7 +569,7 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer) | |||
569 | push_dl_task(rq); | 569 | push_dl_task(rq); |
570 | #endif | 570 | #endif |
571 | unlock: | 571 | unlock: |
572 | task_rq_unlock(rq, current, &flags); | 572 | task_rq_unlock(rq, p, &flags); |
573 | 573 | ||
574 | return HRTIMER_NORESTART; | 574 | return HRTIMER_NORESTART; |
575 | } | 575 | } |