diff options
author | Haneen Mohammed <hamohammed.sa@gmail.com> | 2017-09-20 14:54:48 -0400 |
---|---|---|
committer | Sean Paul <seanpaul@chromium.org> | 2017-10-16 15:01:51 -0400 |
commit | 4c3cf375bc4042eb8682cc6f4314efe66990421a (patch) | |
tree | f206a15a46ce911a4f7f0bc2c9a87b705179db9a | |
parent | e0ad7c0f37478853f12a723f46f87cd672ca9d67 (diff) |
drm/armada: Replace drm_gem_object_reference/unreference() with _get/put()
This patch replace instances of drm_gem_object_reference/unreference with
*_get/put() suffixes, because get/put is shorter and consistent with the
kernel use of *_get/put() suffixes.
This was done with the following Coccinelle script:
@r1@
expression e;
@@
(
-drm_gem_object_reference(e);
+drm_gem_object_get(e);
|
-drm_gem_object_unreference(e);
+drm_gem_object_put(e);
|
-drm_gem_object_unreference_unlocked(e);
+drm_gem_object_put_unlocked(e);
)
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
[resolved small conflict with removed armada_gem_dumb_map_offset]
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/a59ef1ed109ade897bcffcb01b33214262db8942.1505932812.git.hamohammed.sa@gmail.com
-rw-r--r-- | drivers/gpu/drm/armada/armada_crtc.c | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/armada/armada_fb.c | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/armada/armada_fbdev.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/armada/armada_gem.c | 12 |
4 files changed, 17 insertions, 17 deletions
diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c index 2a4d163ac76f..381dfa104cbb 100644 --- a/drivers/gpu/drm/armada/armada_crtc.c +++ b/drivers/gpu/drm/armada/armada_crtc.c | |||
@@ -947,13 +947,13 @@ static int armada_drm_crtc_cursor_set(struct drm_crtc *crtc, | |||
947 | 947 | ||
948 | /* Must be a kernel-mapped object */ | 948 | /* Must be a kernel-mapped object */ |
949 | if (!obj->addr) { | 949 | if (!obj->addr) { |
950 | drm_gem_object_unreference_unlocked(&obj->obj); | 950 | drm_gem_object_put_unlocked(&obj->obj); |
951 | return -EINVAL; | 951 | return -EINVAL; |
952 | } | 952 | } |
953 | 953 | ||
954 | if (obj->obj.size < w * h * 4) { | 954 | if (obj->obj.size < w * h * 4) { |
955 | DRM_ERROR("buffer is too small\n"); | 955 | DRM_ERROR("buffer is too small\n"); |
956 | drm_gem_object_unreference_unlocked(&obj->obj); | 956 | drm_gem_object_put_unlocked(&obj->obj); |
957 | return -ENOMEM; | 957 | return -ENOMEM; |
958 | } | 958 | } |
959 | } | 959 | } |
@@ -961,7 +961,7 @@ static int armada_drm_crtc_cursor_set(struct drm_crtc *crtc, | |||
961 | if (dcrtc->cursor_obj) { | 961 | if (dcrtc->cursor_obj) { |
962 | dcrtc->cursor_obj->update = NULL; | 962 | dcrtc->cursor_obj->update = NULL; |
963 | dcrtc->cursor_obj->update_data = NULL; | 963 | dcrtc->cursor_obj->update_data = NULL; |
964 | drm_gem_object_unreference_unlocked(&dcrtc->cursor_obj->obj); | 964 | drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj); |
965 | } | 965 | } |
966 | dcrtc->cursor_obj = obj; | 966 | dcrtc->cursor_obj = obj; |
967 | dcrtc->cursor_w = w; | 967 | dcrtc->cursor_w = w; |
@@ -997,7 +997,7 @@ static void armada_drm_crtc_destroy(struct drm_crtc *crtc) | |||
997 | struct armada_private *priv = crtc->dev->dev_private; | 997 | struct armada_private *priv = crtc->dev->dev_private; |
998 | 998 | ||
999 | if (dcrtc->cursor_obj) | 999 | if (dcrtc->cursor_obj) |
1000 | drm_gem_object_unreference_unlocked(&dcrtc->cursor_obj->obj); | 1000 | drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj); |
1001 | 1001 | ||
1002 | priv->dcrtc[dcrtc->num] = NULL; | 1002 | priv->dcrtc[dcrtc->num] = NULL; |
1003 | drm_crtc_cleanup(&dcrtc->crtc); | 1003 | drm_crtc_cleanup(&dcrtc->crtc); |
diff --git a/drivers/gpu/drm/armada/armada_fb.c b/drivers/gpu/drm/armada/armada_fb.c index b9e1637cc4cf..a38d5a0892a9 100644 --- a/drivers/gpu/drm/armada/armada_fb.c +++ b/drivers/gpu/drm/armada/armada_fb.c | |||
@@ -17,7 +17,7 @@ static void armada_fb_destroy(struct drm_framebuffer *fb) | |||
17 | struct armada_framebuffer *dfb = drm_fb_to_armada_fb(fb); | 17 | struct armada_framebuffer *dfb = drm_fb_to_armada_fb(fb); |
18 | 18 | ||
19 | drm_framebuffer_cleanup(&dfb->fb); | 19 | drm_framebuffer_cleanup(&dfb->fb); |
20 | drm_gem_object_unreference_unlocked(&dfb->obj->obj); | 20 | drm_gem_object_put_unlocked(&dfb->obj->obj); |
21 | kfree(dfb); | 21 | kfree(dfb); |
22 | } | 22 | } |
23 | 23 | ||
@@ -94,7 +94,7 @@ struct armada_framebuffer *armada_framebuffer_create(struct drm_device *dev, | |||
94 | * the above call, but the caller will drop their reference | 94 | * the above call, but the caller will drop their reference |
95 | * to it. Hence we need to take our own reference. | 95 | * to it. Hence we need to take our own reference. |
96 | */ | 96 | */ |
97 | drm_gem_object_reference(&obj->obj); | 97 | drm_gem_object_get(&obj->obj); |
98 | 98 | ||
99 | return dfb; | 99 | return dfb; |
100 | } | 100 | } |
@@ -143,12 +143,12 @@ static struct drm_framebuffer *armada_fb_create(struct drm_device *dev, | |||
143 | goto err; | 143 | goto err; |
144 | } | 144 | } |
145 | 145 | ||
146 | drm_gem_object_unreference_unlocked(&obj->obj); | 146 | drm_gem_object_put_unlocked(&obj->obj); |
147 | 147 | ||
148 | return &dfb->fb; | 148 | return &dfb->fb; |
149 | 149 | ||
150 | err_unref: | 150 | err_unref: |
151 | drm_gem_object_unreference_unlocked(&obj->obj); | 151 | drm_gem_object_put_unlocked(&obj->obj); |
152 | err: | 152 | err: |
153 | DRM_ERROR("failed to initialize framebuffer: %d\n", ret); | 153 | DRM_ERROR("failed to initialize framebuffer: %d\n", ret); |
154 | return ERR_PTR(ret); | 154 | return ERR_PTR(ret); |
diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c index 10e3fd87a83b..a2ce83f84800 100644 --- a/drivers/gpu/drm/armada/armada_fbdev.c +++ b/drivers/gpu/drm/armada/armada_fbdev.c | |||
@@ -51,13 +51,13 @@ static int armada_fb_create(struct drm_fb_helper *fbh, | |||
51 | 51 | ||
52 | ret = armada_gem_linear_back(dev, obj); | 52 | ret = armada_gem_linear_back(dev, obj); |
53 | if (ret) { | 53 | if (ret) { |
54 | drm_gem_object_unreference_unlocked(&obj->obj); | 54 | drm_gem_object_put_unlocked(&obj->obj); |
55 | return ret; | 55 | return ret; |
56 | } | 56 | } |
57 | 57 | ||
58 | ptr = armada_gem_map_object(dev, obj); | 58 | ptr = armada_gem_map_object(dev, obj); |
59 | if (!ptr) { | 59 | if (!ptr) { |
60 | drm_gem_object_unreference_unlocked(&obj->obj); | 60 | drm_gem_object_put_unlocked(&obj->obj); |
61 | return -ENOMEM; | 61 | return -ENOMEM; |
62 | } | 62 | } |
63 | 63 | ||
@@ -67,7 +67,7 @@ static int armada_fb_create(struct drm_fb_helper *fbh, | |||
67 | * A reference is now held by the framebuffer object if | 67 | * A reference is now held by the framebuffer object if |
68 | * successful, otherwise this drops the ref for the error path. | 68 | * successful, otherwise this drops the ref for the error path. |
69 | */ | 69 | */ |
70 | drm_gem_object_unreference_unlocked(&obj->obj); | 70 | drm_gem_object_put_unlocked(&obj->obj); |
71 | 71 | ||
72 | if (IS_ERR(dfb)) | 72 | if (IS_ERR(dfb)) |
73 | return PTR_ERR(dfb); | 73 | return PTR_ERR(dfb); |
diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index 7837e6adb16f..a97f509743a5 100644 --- a/drivers/gpu/drm/armada/armada_gem.c +++ b/drivers/gpu/drm/armada/armada_gem.c | |||
@@ -265,7 +265,7 @@ int armada_gem_dumb_create(struct drm_file *file, struct drm_device *dev, | |||
265 | /* drop reference from allocate - handle holds it now */ | 265 | /* drop reference from allocate - handle holds it now */ |
266 | DRM_DEBUG_DRIVER("obj %p size %zu handle %#x\n", dobj, size, handle); | 266 | DRM_DEBUG_DRIVER("obj %p size %zu handle %#x\n", dobj, size, handle); |
267 | err: | 267 | err: |
268 | drm_gem_object_unreference_unlocked(&dobj->obj); | 268 | drm_gem_object_put_unlocked(&dobj->obj); |
269 | return ret; | 269 | return ret; |
270 | } | 270 | } |
271 | 271 | ||
@@ -297,7 +297,7 @@ int armada_gem_create_ioctl(struct drm_device *dev, void *data, | |||
297 | /* drop reference from allocate - handle holds it now */ | 297 | /* drop reference from allocate - handle holds it now */ |
298 | DRM_DEBUG_DRIVER("obj %p size %zu handle %#x\n", dobj, size, handle); | 298 | DRM_DEBUG_DRIVER("obj %p size %zu handle %#x\n", dobj, size, handle); |
299 | err: | 299 | err: |
300 | drm_gem_object_unreference_unlocked(&dobj->obj); | 300 | drm_gem_object_put_unlocked(&dobj->obj); |
301 | return ret; | 301 | return ret; |
302 | } | 302 | } |
303 | 303 | ||
@@ -314,13 +314,13 @@ int armada_gem_mmap_ioctl(struct drm_device *dev, void *data, | |||
314 | return -ENOENT; | 314 | return -ENOENT; |
315 | 315 | ||
316 | if (!dobj->obj.filp) { | 316 | if (!dobj->obj.filp) { |
317 | drm_gem_object_unreference_unlocked(&dobj->obj); | 317 | drm_gem_object_put_unlocked(&dobj->obj); |
318 | return -EINVAL; | 318 | return -EINVAL; |
319 | } | 319 | } |
320 | 320 | ||
321 | addr = vm_mmap(dobj->obj.filp, 0, args->size, PROT_READ | PROT_WRITE, | 321 | addr = vm_mmap(dobj->obj.filp, 0, args->size, PROT_READ | PROT_WRITE, |
322 | MAP_SHARED, args->offset); | 322 | MAP_SHARED, args->offset); |
323 | drm_gem_object_unreference_unlocked(&dobj->obj); | 323 | drm_gem_object_put_unlocked(&dobj->obj); |
324 | if (IS_ERR_VALUE(addr)) | 324 | if (IS_ERR_VALUE(addr)) |
325 | return addr; | 325 | return addr; |
326 | 326 | ||
@@ -375,7 +375,7 @@ int armada_gem_pwrite_ioctl(struct drm_device *dev, void *data, | |||
375 | } | 375 | } |
376 | 376 | ||
377 | unref: | 377 | unref: |
378 | drm_gem_object_unreference_unlocked(&dobj->obj); | 378 | drm_gem_object_put_unlocked(&dobj->obj); |
379 | return ret; | 379 | return ret; |
380 | } | 380 | } |
381 | 381 | ||
@@ -524,7 +524,7 @@ armada_gem_prime_import(struct drm_device *dev, struct dma_buf *buf) | |||
524 | * Importing our own dmabuf(s) increases the | 524 | * Importing our own dmabuf(s) increases the |
525 | * refcount on the gem object itself. | 525 | * refcount on the gem object itself. |
526 | */ | 526 | */ |
527 | drm_gem_object_reference(obj); | 527 | drm_gem_object_get(obj); |
528 | return obj; | 528 | return obj; |
529 | } | 529 | } |
530 | } | 530 | } |