aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnson Huang <Anson.Huang@nxp.com>2019-05-24 01:51:01 -0400
committerShawn Guo <shawnguo@kernel.org>2019-06-05 02:09:24 -0400
commit4c396a604a57da8f883a8b3368d83181680d6907 (patch)
treeeb43d32adfcc342d6f974af60277bc071e080b0a
parentd8dfab0f4d0669ae299511e3ab3e79f312476f75 (diff)
soc: imx: soc-imx8: Correct return value of error handle
Current implementation of i.MX8 SoC driver returns -ENODEV for all cases of error during initialization, this is incorrect. This patch fixes them using correct return value according to different errors. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
-rw-r--r--drivers/soc/imx/soc-imx8.c16
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index d377a90f3a2f..0a8681f208d3 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -102,7 +102,7 @@ static int __init imx8_soc_init(void)
102 102
103 soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); 103 soc_dev_attr = kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
104 if (!soc_dev_attr) 104 if (!soc_dev_attr)
105 return -ENODEV; 105 return -ENOMEM;
106 106
107 soc_dev_attr->family = "Freescale i.MX"; 107 soc_dev_attr->family = "Freescale i.MX";
108 108
@@ -112,8 +112,10 @@ static int __init imx8_soc_init(void)
112 goto free_soc; 112 goto free_soc;
113 113
114 id = of_match_node(imx8_soc_match, root); 114 id = of_match_node(imx8_soc_match, root);
115 if (!id) 115 if (!id) {
116 ret = -ENODEV;
116 goto free_soc; 117 goto free_soc;
118 }
117 119
118 data = id->data; 120 data = id->data;
119 if (data) { 121 if (data) {
@@ -123,12 +125,16 @@ static int __init imx8_soc_init(void)
123 } 125 }
124 126
125 soc_dev_attr->revision = imx8_revision(soc_rev); 127 soc_dev_attr->revision = imx8_revision(soc_rev);
126 if (!soc_dev_attr->revision) 128 if (!soc_dev_attr->revision) {
129 ret = -ENOMEM;
127 goto free_soc; 130 goto free_soc;
131 }
128 132
129 soc_dev = soc_device_register(soc_dev_attr); 133 soc_dev = soc_device_register(soc_dev_attr);
130 if (IS_ERR(soc_dev)) 134 if (IS_ERR(soc_dev)) {
135 ret = PTR_ERR(soc_dev);
131 goto free_rev; 136 goto free_rev;
137 }
132 138
133 of_node_put(root); 139 of_node_put(root);
134 140
@@ -139,6 +145,6 @@ free_rev:
139free_soc: 145free_soc:
140 kfree(soc_dev_attr); 146 kfree(soc_dev_attr);
141 of_node_put(root); 147 of_node_put(root);
142 return -ENODEV; 148 return ret;
143} 149}
144device_initcall(imx8_soc_init); 150device_initcall(imx8_soc_init);