aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBhumika Goyal <bhumirks@gmail.com>2016-02-26 05:04:30 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-03-12 01:09:09 -0500
commit4b25ce977e43f55f88df30a4d338b63bb597fdef (patch)
tree48b25a45f5d96f0f6c4fd37c85a6665ef5ac1de4
parent37491cd6fcf6474262fbff9c10208a8105573abf (diff)
Staging: rtl8723au: Use min macro instead of ternary operator
This patch replaces ternary operator with macro min as it shorter and thus increases code readability. Macro min return the minimum of the two compared values. Made a semantic patch for changes: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
index 8850898dc53d..e64b7e14341e 100644
--- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
@@ -543,7 +543,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, u8 key_index,
543 memcpy(psecuritypriv-> 543 memcpy(psecuritypriv->
544 dot118021XGrpKey[key_index].skey, 544 dot118021XGrpKey[key_index].skey,
545 keyparms->key, 545 keyparms->key,
546 (key_len > 16 ? 16 : key_len)); 546 (min(16, key_len)));
547 547
548 /* set mic key */ 548 /* set mic key */
549 memcpy(psecuritypriv-> 549 memcpy(psecuritypriv->
@@ -565,7 +565,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, u8 key_index,
565 memcpy(psecuritypriv-> 565 memcpy(psecuritypriv->
566 dot118021XGrpKey[key_index].skey, 566 dot118021XGrpKey[key_index].skey,
567 keyparms->key, 567 keyparms->key,
568 (key_len > 16 ? 16 : key_len)); 568 (min(16, key_len)));
569 } else { 569 } else {
570 DBG_8723A("%s, set group_key, none\n", 570 DBG_8723A("%s, set group_key, none\n",
571 __func__); 571 __func__);
@@ -603,7 +603,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, u8 key_index,
603 if (set_tx == 1) { 603 if (set_tx == 1) {
604 /* pairwise key */ 604 /* pairwise key */
605 memcpy(psta->dot118021x_UncstKey.skey, 605 memcpy(psta->dot118021x_UncstKey.skey,
606 keyparms->key, (key_len > 16 ? 16 : key_len)); 606 keyparms->key, (min(16, key_len)));
607 607
608 if (keyparms->cipher == WLAN_CIPHER_SUITE_WEP40 || 608 if (keyparms->cipher == WLAN_CIPHER_SUITE_WEP40 ||
609 keyparms->cipher == WLAN_CIPHER_SUITE_WEP104) { 609 keyparms->cipher == WLAN_CIPHER_SUITE_WEP104) {
@@ -661,7 +661,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, u8 key_index,
661 memcpy(psecuritypriv-> 661 memcpy(psecuritypriv->
662 dot118021XGrpKey[key_index].skey, 662 dot118021XGrpKey[key_index].skey,
663 keyparms->key, 663 keyparms->key,
664 (key_len > 16 ? 16 : key_len)); 664 (min(16, key_len)));
665 665
666 /* set mic key */ 666 /* set mic key */
667 memcpy(psecuritypriv-> 667 memcpy(psecuritypriv->
@@ -679,7 +679,7 @@ static int rtw_cfg80211_ap_set_encryption(struct net_device *dev, u8 key_index,
679 memcpy(psecuritypriv-> 679 memcpy(psecuritypriv->
680 dot118021XGrpKey[key_index].skey, 680 dot118021XGrpKey[key_index].skey,
681 keyparms->key, 681 keyparms->key,
682 (key_len > 16 ? 16 : key_len)); 682 (min(16, key_len)));
683 } else { 683 } else {
684 psecuritypriv->dot118021XGrpPrivacy = 0; 684 psecuritypriv->dot118021XGrpPrivacy = 0;
685 } 685 }
@@ -789,7 +789,7 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, u8 key_index,
789 789
790 memcpy(psta->dot118021x_UncstKey.skey, 790 memcpy(psta->dot118021x_UncstKey.skey,
791 keyparms->key, 791 keyparms->key,
792 (key_len > 16 ? 16 : key_len)); 792 (min(16, key_len)));
793 793
794 if (keyparms->cipher == 794 if (keyparms->cipher ==
795 WLAN_CIPHER_SUITE_TKIP) { 795 WLAN_CIPHER_SUITE_TKIP) {
@@ -812,7 +812,7 @@ static int rtw_cfg80211_set_encryption(struct net_device *dev, u8 key_index,
812 memcpy(padapter->securitypriv. 812 memcpy(padapter->securitypriv.
813 dot118021XGrpKey[key_index].skey, 813 dot118021XGrpKey[key_index].skey,
814 keyparms->key, 814 keyparms->key,
815 (key_len > 16 ? 16 : key_len)); 815 (min(16, key_len)));
816 memcpy(padapter->securitypriv. 816 memcpy(padapter->securitypriv.
817 dot118021XGrptxmickey[key_index]. 817 dot118021XGrptxmickey[key_index].
818 skey, &keyparms->key[16], 8); 818 skey, &keyparms->key[16], 8);