aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-06-13 09:23:33 -0400
committerDarren Hart <dvhart@linux.intel.com>2015-06-15 16:28:03 -0400
commit4b200b4604bec3388426159f1656109d19fadf6e (patch)
treecfb2bc7df3208db207707559be1daf2171286a7b
parentf8358578e2f23bd82d0454c17676bdb28a40664a (diff)
ideapad: fix software rfkill setting
This fixes a several year old regression that I found while trying to get the Yoga 3 11 to work. The ideapad_rfk_set function is meant to send a command to the embedded controller through ACPI, but as of c1f73658ed, it sends the index of the rfkill device instead of the command, and ignores the opcode field. This changes it back to the original behavior, which indeed flips the rfkill state as seen in the debugfs interface. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: c1f73658ed ("ideapad: pass ideapad_priv as argument (part 2)") Cc: stable@vger.kernel.org # v2.6.38+ Signed-off-by: Darren Hart <dvhart@linux.intel.com>
-rw-r--r--drivers/platform/x86/ideapad-laptop.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 1db3d2176d56..1bd34dbfe73a 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -464,8 +464,9 @@ static const struct ideapad_rfk_data ideapad_rfk_data[] = {
464static int ideapad_rfk_set(void *data, bool blocked) 464static int ideapad_rfk_set(void *data, bool blocked)
465{ 465{
466 struct ideapad_rfk_priv *priv = data; 466 struct ideapad_rfk_priv *priv = data;
467 int opcode = ideapad_rfk_data[priv->dev].opcode;
467 468
468 return write_ec_cmd(priv->priv->adev->handle, priv->dev, !blocked); 469 return write_ec_cmd(priv->priv->adev->handle, opcode, !blocked);
469} 470}
470 471
471static struct rfkill_ops ideapad_rfk_ops = { 472static struct rfkill_ops ideapad_rfk_ops = {