aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2018-07-01 15:32:19 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2018-07-01 15:32:19 -0400
commit4a770e638f531d078b580a5a24412c5e5f8f7ddb (patch)
treefde3fdcf9f6fc3bbafaa8ed0964f689cb5b79c57
parentd7563ca5bfca53398e100eb74345c5d3ef06bf9d (diff)
parent877f919e192a09e77962a13d7165783027dee5fd (diff)
Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs fix from Al Viro: "Followup to procfs-seq_file series this window" This fixes a memory leak by making sure that proc seq files release any private data on close. The 'proc_seq_open' has to be properly paired with 'proc_seq_release' that releases the extra private data. * 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: proc: add proc_seq_release
-rw-r--r--fs/proc/generic.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 6ac1c92997ea..bb1c1625b158 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -564,11 +564,20 @@ static int proc_seq_open(struct inode *inode, struct file *file)
564 return seq_open(file, de->seq_ops); 564 return seq_open(file, de->seq_ops);
565} 565}
566 566
567static int proc_seq_release(struct inode *inode, struct file *file)
568{
569 struct proc_dir_entry *de = PDE(inode);
570
571 if (de->state_size)
572 return seq_release_private(inode, file);
573 return seq_release(inode, file);
574}
575
567static const struct file_operations proc_seq_fops = { 576static const struct file_operations proc_seq_fops = {
568 .open = proc_seq_open, 577 .open = proc_seq_open,
569 .read = seq_read, 578 .read = seq_read,
570 .llseek = seq_lseek, 579 .llseek = seq_lseek,
571 .release = seq_release, 580 .release = proc_seq_release,
572}; 581};
573 582
574struct proc_dir_entry *proc_create_seq_private(const char *name, umode_t mode, 583struct proc_dir_entry *proc_create_seq_private(const char *name, umode_t mode,