aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Zijlstra <peterz@infradead.org>2019-03-07 05:09:13 -0500
committerIngo Molnar <mingo@kernel.org>2019-04-03 05:02:24 -0400
commit4a6c91fbdef846ec7250b82f2eeeb87ac5f18cf9 (patch)
tree4bc04f2fe05326071feb0d560de2489a899f2d04
parentd08965a27e84ca090b504844d50c24fc98587b11 (diff)
x86/uaccess, ftrace: Fix ftrace_likely_update() vs. SMAP
For CONFIG_TRACE_BRANCH_PROFILING=y the likely/unlikely things get overloaded and generate callouts to this code, and thus also when AC=1. Make it safe. Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--kernel/trace/trace_branch.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index 4ad967453b6f..3ea65cdff30d 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -205,6 +205,8 @@ void trace_likely_condition(struct ftrace_likely_data *f, int val, int expect)
205void ftrace_likely_update(struct ftrace_likely_data *f, int val, 205void ftrace_likely_update(struct ftrace_likely_data *f, int val,
206 int expect, int is_constant) 206 int expect, int is_constant)
207{ 207{
208 unsigned long flags = user_access_save();
209
208 /* A constant is always correct */ 210 /* A constant is always correct */
209 if (is_constant) { 211 if (is_constant) {
210 f->constant++; 212 f->constant++;
@@ -223,6 +225,8 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
223 f->data.correct++; 225 f->data.correct++;
224 else 226 else
225 f->data.incorrect++; 227 f->data.incorrect++;
228
229 user_access_restore(flags);
226} 230}
227EXPORT_SYMBOL(ftrace_likely_update); 231EXPORT_SYMBOL(ftrace_likely_update);
228 232