diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2017-06-14 06:40:36 -0400 |
|---|---|---|
| committer | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2017-06-14 06:40:36 -0400 |
| commit | 484c7bbf2649831714da3a0fa30213977458e9b5 (patch) | |
| tree | 16d0ea0706a1f06e106ff3e53e4e9d4a52948d02 | |
| parent | 1235185521ba0d9528052578e27c2f4999d489c6 (diff) | |
video: fbdev: via: remove possibly unused variables
When CONFIG_PROC_FS is disabled, we get warnings about unused variables
as remove_proc_entry() evaluates to an empty macro.
drivers/video/fbdev/via/viafbdev.c: In function 'viafb_remove_proc':
drivers/video/fbdev/via/viafbdev.c:1635:4: error: unused variable 'iga2_entry' [-Werror=unused-variable]
drivers/video/fbdev/via/viafbdev.c:1634:4: error: unused variable 'iga1_entry' [-Werror=unused-variable]
These are easy to avoid by using the pointer from the structure.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
| -rw-r--r-- | drivers/video/fbdev/via/viafbdev.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c index f9718f012aae..badee04ef496 100644 --- a/drivers/video/fbdev/via/viafbdev.c +++ b/drivers/video/fbdev/via/viafbdev.c | |||
| @@ -1630,16 +1630,14 @@ static void viafb_init_proc(struct viafb_shared *shared) | |||
| 1630 | } | 1630 | } |
| 1631 | static void viafb_remove_proc(struct viafb_shared *shared) | 1631 | static void viafb_remove_proc(struct viafb_shared *shared) |
| 1632 | { | 1632 | { |
| 1633 | struct proc_dir_entry *viafb_entry = shared->proc_entry, | 1633 | struct proc_dir_entry *viafb_entry = shared->proc_entry; |
| 1634 | *iga1_entry = shared->iga1_proc_entry, | ||
| 1635 | *iga2_entry = shared->iga2_proc_entry; | ||
| 1636 | 1634 | ||
| 1637 | if (!viafb_entry) | 1635 | if (!viafb_entry) |
| 1638 | return; | 1636 | return; |
| 1639 | 1637 | ||
| 1640 | remove_proc_entry("output_devices", iga2_entry); | 1638 | remove_proc_entry("output_devices", shared->iga2_proc_entry); |
| 1641 | remove_proc_entry("iga2", viafb_entry); | 1639 | remove_proc_entry("iga2", viafb_entry); |
| 1642 | remove_proc_entry("output_devices", iga1_entry); | 1640 | remove_proc_entry("output_devices", shared->iga1_proc_entry); |
| 1643 | remove_proc_entry("iga1", viafb_entry); | 1641 | remove_proc_entry("iga1", viafb_entry); |
| 1644 | remove_proc_entry("supported_output_devices", viafb_entry); | 1642 | remove_proc_entry("supported_output_devices", viafb_entry); |
| 1645 | 1643 | ||
