diff options
author | Ryan Case <ryandcase@chromium.org> | 2018-10-22 21:07:07 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2018-11-22 09:38:13 -0500 |
commit | 478652f3d45cc6f0ef9be3cda8b13fcd85076fa6 (patch) | |
tree | a4fe1a57afc33219e6bd4ee4e7510f219ea2c674 | |
parent | 1fc12b05895ea50386f0e666f84053f0c8307943 (diff) |
spi: spi-qcom-qspi: Fix remaining driver nits
Address remaining comments from original driver patch series
* Move RD_FIFO_CFG to be ordered corretly
* Expand spinlock comment
Signed-off-by: Ryan Case <ryandcase@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/spi/spi-qcom-qspi.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/spi/spi-qcom-qspi.c b/drivers/spi/spi-qcom-qspi.c index b8163b40bb92..e0f061139c8f 100644 --- a/drivers/spi/spi-qcom-qspi.c +++ b/drivers/spi/spi-qcom-qspi.c | |||
@@ -90,6 +90,9 @@ | |||
90 | #define PIO_DATAOUT_1B 0x0020 | 90 | #define PIO_DATAOUT_1B 0x0020 |
91 | #define PIO_DATAOUT_4B 0x0024 | 91 | #define PIO_DATAOUT_4B 0x0024 |
92 | 92 | ||
93 | #define RD_FIFO_CFG 0x0028 | ||
94 | #define CONTINUOUS_MODE BIT(0) | ||
95 | |||
93 | #define RD_FIFO_STATUS 0x002c | 96 | #define RD_FIFO_STATUS 0x002c |
94 | #define FIFO_EMPTY BIT(11) | 97 | #define FIFO_EMPTY BIT(11) |
95 | #define WR_CNTS_MSK 0x7f0 | 98 | #define WR_CNTS_MSK 0x7f0 |
@@ -99,9 +102,6 @@ | |||
99 | #define RDY_16BYTE BIT(1) | 102 | #define RDY_16BYTE BIT(1) |
100 | #define FIFO_RDY BIT(0) | 103 | #define FIFO_RDY BIT(0) |
101 | 104 | ||
102 | #define RD_FIFO_CFG 0x0028 | ||
103 | #define CONTINUOUS_MODE BIT(0) | ||
104 | |||
105 | #define RD_FIFO_RESET 0x0030 | 105 | #define RD_FIFO_RESET 0x0030 |
106 | #define RESET_FIFO BIT(0) | 106 | #define RESET_FIFO BIT(0) |
107 | 107 | ||
@@ -139,7 +139,7 @@ struct qcom_qspi { | |||
139 | struct device *dev; | 139 | struct device *dev; |
140 | struct clk_bulk_data clks[QSPI_NUM_CLKS]; | 140 | struct clk_bulk_data clks[QSPI_NUM_CLKS]; |
141 | struct qspi_xfer xfer; | 141 | struct qspi_xfer xfer; |
142 | /* Lock to protect data accessed by IRQs */ | 142 | /* Lock to protect xfer and IRQ accessed registers */ |
143 | spinlock_t lock; | 143 | spinlock_t lock; |
144 | }; | 144 | }; |
145 | 145 | ||