diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2012-08-05 10:59:12 -0400 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2012-10-07 04:33:12 -0400 |
| commit | 45ef6ac6f5d4d4ea441a042fee3790b3f33cba73 (patch) | |
| tree | 29897e692ff81474a9a74f0a27ce957b49cdc7e3 | |
| parent | edc9e3334a19efe1f0c1d2dc7df354e77c8d535d (diff) | |
ARM: footbridge: nw_gpio_lock is raw_spin_lock
bd31b85960a "locking, ARM: Annotate low level hw locks as raw"
made nw_gpio_lock a raw spinlock, but did not change all the
users in device drivers. This fixes the remaining ones.
sound/oss/waveartist.c: In function 'vnc_mute_spkr':
sound/oss/waveartist.c:1485:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default]
include/linux/spinlock.h:272:102: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
drivers/char/ds1620.c: In function 'netwinder_lock':
drivers/char/ds1620.c:77:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default]
include/linux/spinlock.h:272:102: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
drivers/char/nwflash.c: In function 'kick_open':
drivers/char/nwflash.c:620:2: warning: passing argument 1 of 'spinlock_check' from incompatible pointer type [enabled by default]
include/linux/spinlock.h:272:102: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
| -rw-r--r-- | drivers/char/ds1620.c | 8 | ||||
| -rw-r--r-- | drivers/char/nwflash.c | 4 | ||||
| -rw-r--r-- | sound/oss/waveartist.c | 4 |
3 files changed, 8 insertions, 8 deletions
diff --git a/drivers/char/ds1620.c b/drivers/char/ds1620.c index aab9605f0b43..24ffd8cec51e 100644 --- a/drivers/char/ds1620.c +++ b/drivers/char/ds1620.c | |||
| @@ -74,21 +74,21 @@ static inline void netwinder_ds1620_reset(void) | |||
| 74 | 74 | ||
| 75 | static inline void netwinder_lock(unsigned long *flags) | 75 | static inline void netwinder_lock(unsigned long *flags) |
| 76 | { | 76 | { |
| 77 | spin_lock_irqsave(&nw_gpio_lock, *flags); | 77 | raw_spin_lock_irqsave(&nw_gpio_lock, *flags); |
| 78 | } | 78 | } |
| 79 | 79 | ||
| 80 | static inline void netwinder_unlock(unsigned long *flags) | 80 | static inline void netwinder_unlock(unsigned long *flags) |
| 81 | { | 81 | { |
| 82 | spin_unlock_irqrestore(&nw_gpio_lock, *flags); | 82 | raw_spin_unlock_irqrestore(&nw_gpio_lock, *flags); |
| 83 | } | 83 | } |
| 84 | 84 | ||
| 85 | static inline void netwinder_set_fan(int i) | 85 | static inline void netwinder_set_fan(int i) |
| 86 | { | 86 | { |
| 87 | unsigned long flags; | 87 | unsigned long flags; |
| 88 | 88 | ||
| 89 | spin_lock_irqsave(&nw_gpio_lock, flags); | 89 | raw_spin_lock_irqsave(&nw_gpio_lock, flags); |
| 90 | nw_gpio_modify_op(GPIO_FAN, i ? GPIO_FAN : 0); | 90 | nw_gpio_modify_op(GPIO_FAN, i ? GPIO_FAN : 0); |
| 91 | spin_unlock_irqrestore(&nw_gpio_lock, flags); | 91 | raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); |
| 92 | } | 92 | } |
| 93 | 93 | ||
| 94 | static inline int netwinder_get_fan(void) | 94 | static inline int netwinder_get_fan(void) |
diff --git a/drivers/char/nwflash.c b/drivers/char/nwflash.c index d45c3345b4af..04e2a9491fca 100644 --- a/drivers/char/nwflash.c +++ b/drivers/char/nwflash.c | |||
| @@ -617,9 +617,9 @@ static void kick_open(void) | |||
| 617 | * we want to write a bit pattern XXX1 to Xilinx to enable | 617 | * we want to write a bit pattern XXX1 to Xilinx to enable |
| 618 | * the write gate, which will be open for about the next 2ms. | 618 | * the write gate, which will be open for about the next 2ms. |
| 619 | */ | 619 | */ |
| 620 | spin_lock_irqsave(&nw_gpio_lock, flags); | 620 | raw_spin_lock_irqsave(&nw_gpio_lock, flags); |
| 621 | nw_cpld_modify(CPLD_FLASH_WR_ENABLE, CPLD_FLASH_WR_ENABLE); | 621 | nw_cpld_modify(CPLD_FLASH_WR_ENABLE, CPLD_FLASH_WR_ENABLE); |
| 622 | spin_unlock_irqrestore(&nw_gpio_lock, flags); | 622 | raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); |
| 623 | 623 | ||
| 624 | /* | 624 | /* |
| 625 | * let the ISA bus to catch on... | 625 | * let the ISA bus to catch on... |
diff --git a/sound/oss/waveartist.c b/sound/oss/waveartist.c index 24c430f721d4..672af8b56542 100644 --- a/sound/oss/waveartist.c +++ b/sound/oss/waveartist.c | |||
| @@ -1482,9 +1482,9 @@ vnc_mute_spkr(wavnc_info *devc) | |||
| 1482 | { | 1482 | { |
| 1483 | unsigned long flags; | 1483 | unsigned long flags; |
| 1484 | 1484 | ||
| 1485 | spin_lock_irqsave(&nw_gpio_lock, flags); | 1485 | raw_spin_lock_irqsave(&nw_gpio_lock, flags); |
| 1486 | nw_cpld_modify(CPLD_UNMUTE, devc->spkr_mute_state ? 0 : CPLD_UNMUTE); | 1486 | nw_cpld_modify(CPLD_UNMUTE, devc->spkr_mute_state ? 0 : CPLD_UNMUTE); |
| 1487 | spin_unlock_irqrestore(&nw_gpio_lock, flags); | 1487 | raw_spin_unlock_irqrestore(&nw_gpio_lock, flags); |
| 1488 | } | 1488 | } |
| 1489 | 1489 | ||
| 1490 | static void | 1490 | static void |
