diff options
author | Steve French <smfrench@gmail.com> | 2017-10-25 16:58:31 -0400 |
---|---|---|
committer | Steve French <smfrench@gmail.com> | 2017-10-26 13:20:59 -0400 |
commit | 4587eee04e2ac7ac3ac9fa2bc164fb6e548f99cd (patch) | |
tree | a852e0565e761bfec1613e71b8846d5e10e10f64 | |
parent | a2d9daad1d2dfbd307ab158044d1c323d7babbde (diff) |
SMB3: Validate negotiate request must always be signed
According to MS-SMB2 3.2.55 validate_negotiate request must
always be signed. Some Windows can fail the request if you send it unsigned
See kernel bugzilla bug 197311
CC: Stable <stable@vger.kernel.org>
Acked-by: Ronnie Sahlberg <lsahlber.redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
-rw-r--r-- | fs/cifs/smb2pdu.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c index ba58af747b43..5331631386a2 100644 --- a/fs/cifs/smb2pdu.c +++ b/fs/cifs/smb2pdu.c | |||
@@ -1979,6 +1979,9 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid, | |||
1979 | } else | 1979 | } else |
1980 | iov[0].iov_len = get_rfc1002_length(req) + 4; | 1980 | iov[0].iov_len = get_rfc1002_length(req) + 4; |
1981 | 1981 | ||
1982 | /* validate negotiate request must be signed - see MS-SMB2 3.2.5.5 */ | ||
1983 | if (opcode == FSCTL_VALIDATE_NEGOTIATE_INFO) | ||
1984 | req->hdr.sync_hdr.Flags |= SMB2_FLAGS_SIGNED; | ||
1982 | 1985 | ||
1983 | rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov); | 1986 | rc = SendReceive2(xid, ses, iov, n_iov, &resp_buftype, flags, &rsp_iov); |
1984 | cifs_small_buf_release(req); | 1987 | cifs_small_buf_release(req); |