diff options
author | Wenwen Wang <wenwen@cs.uga.edu> | 2019-08-15 16:29:51 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-08-18 17:11:28 -0400 |
commit | 44ef3a03252844a8753479b0cea7f29e4a804bdc (patch) | |
tree | a57a078b5ee773603881dabf87ae9dfac30740f9 | |
parent | 3434341004a380f4e47c3a03d4320d43982162a0 (diff) |
wimax/i2400m: fix a memory leak bug
In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
to hold the original command line options. Then, the options are parsed.
However, if an error occurs during the parsing process, 'options_orig' is
not deallocated, leading to a memory leak bug. To fix this issue, free
'options_orig' before returning the error.
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/wimax/i2400m/fw.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/wimax/i2400m/fw.c b/drivers/net/wimax/i2400m/fw.c index e9fc168bb734..489cba9b284d 100644 --- a/drivers/net/wimax/i2400m/fw.c +++ b/drivers/net/wimax/i2400m/fw.c | |||
@@ -351,13 +351,15 @@ int i2400m_barker_db_init(const char *_options) | |||
351 | } | 351 | } |
352 | result = i2400m_barker_db_add(barker); | 352 | result = i2400m_barker_db_add(barker); |
353 | if (result < 0) | 353 | if (result < 0) |
354 | goto error_add; | 354 | goto error_parse_add; |
355 | } | 355 | } |
356 | kfree(options_orig); | 356 | kfree(options_orig); |
357 | } | 357 | } |
358 | return 0; | 358 | return 0; |
359 | 359 | ||
360 | error_parse_add: | ||
360 | error_parse: | 361 | error_parse: |
362 | kfree(options_orig); | ||
361 | error_add: | 363 | error_add: |
362 | kfree(i2400m_barker_db); | 364 | kfree(i2400m_barker_db); |
363 | return result; | 365 | return result; |