diff options
author | Zhouyang Jia <jiazhouyang09@gmail.com> | 2018-06-14 09:37:17 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2018-06-25 09:16:11 -0400 |
commit | 44d4d51de9a3534a2b63d69efda02a10e66541e4 (patch) | |
tree | 70bb5a49708b3b297166a0a4542d7ac34d4356a4 | |
parent | fdea70d26a471e002f2afc3a48821323b699f1e6 (diff) |
HID: hid-ntrig: add error handling for sysfs_create_group
When sysfs_create_group fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling sysfs_create_group.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r-- | drivers/hid/hid-ntrig.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c index 43b1c7234316..9bc6f4867cb3 100644 --- a/drivers/hid/hid-ntrig.c +++ b/drivers/hid/hid-ntrig.c | |||
@@ -955,6 +955,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id) | |||
955 | 955 | ||
956 | ret = sysfs_create_group(&hdev->dev.kobj, | 956 | ret = sysfs_create_group(&hdev->dev.kobj, |
957 | &ntrig_attribute_group); | 957 | &ntrig_attribute_group); |
958 | if (ret) | ||
959 | hid_err(hdev, "cannot create sysfs group\n"); | ||
958 | 960 | ||
959 | return 0; | 961 | return 0; |
960 | err_free: | 962 | err_free: |