diff options
author | Namhyung Kim <namhyung@kernel.org> | 2017-06-08 03:31:02 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2017-06-08 14:38:47 -0400 |
commit | 44ad6b8852529eb39066edbedc027a6901da6803 (patch) | |
tree | b21fa536818dd709a241f83820a5c8b566d692ca | |
parent | 3619ef76b37d4803bc9daee9d03d82c8526db378 (diff) |
perf tools: Fix a memory leak in __open_dso()
The 'name' variable should be freed on the error path.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Cc: kernel-team@lge.com
Link: http://lkml.kernel.org/r/20170608073109.30699-3-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/dso.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index b27d127cdf68..1f29e4fe7af0 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c | |||
@@ -412,8 +412,10 @@ static int __open_dso(struct dso *dso, struct machine *machine) | |||
412 | return -EINVAL; | 412 | return -EINVAL; |
413 | } | 413 | } |
414 | 414 | ||
415 | if (!is_regular_file(name)) | 415 | if (!is_regular_file(name)) { |
416 | free(name); | ||
416 | return -EINVAL; | 417 | return -EINVAL; |
418 | } | ||
417 | 419 | ||
418 | fd = do_open(name); | 420 | fd = do_open(name); |
419 | free(name); | 421 | free(name); |