aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-09-21 11:57:50 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2017-09-21 11:57:50 -0400
commit449cd5d2a08ddf3cb99dc9eb066e494345eb2a92 (patch)
treea426ebb831252623207b7c46c87f947ccdfbfedd
parentd9fde269823620e517fea34b28b41b587c4a81f5 (diff)
parent58aff0af757356065f33290d96a9cd46dfbcae88 (diff)
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull misc fixes from Al Viro: "A couple of regression fixes, one for this merge window, one for the previous cycle" * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: ipc/shm: Fix order of parameters when calling copy_compat_shmid_to_user iov_iter: fix page_copy_sane for compound pages
-rw-r--r--ipc/shm.c2
-rw-r--r--lib/iov_iter.c6
2 files changed, 5 insertions, 3 deletions
diff --git a/ipc/shm.c b/ipc/shm.c
index 1b3adfe3c60e..1e2b1692ba2c 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -1237,7 +1237,7 @@ COMPAT_SYSCALL_DEFINE3(shmctl, int, shmid, int, cmd, void __user *, uptr)
1237 err = shmctl_stat(ns, shmid, cmd, &sem64); 1237 err = shmctl_stat(ns, shmid, cmd, &sem64);
1238 if (err < 0) 1238 if (err < 0)
1239 return err; 1239 return err;
1240 if (copy_compat_shmid_to_user(&sem64, uptr, version)) 1240 if (copy_compat_shmid_to_user(uptr, &sem64, version))
1241 err = -EFAULT; 1241 err = -EFAULT;
1242 return err; 1242 return err;
1243 1243
diff --git a/lib/iov_iter.c b/lib/iov_iter.c
index 52c8dd6d8e82..1c1c06ddc20a 100644
--- a/lib/iov_iter.c
+++ b/lib/iov_iter.c
@@ -687,8 +687,10 @@ EXPORT_SYMBOL(_copy_from_iter_full_nocache);
687 687
688static inline bool page_copy_sane(struct page *page, size_t offset, size_t n) 688static inline bool page_copy_sane(struct page *page, size_t offset, size_t n)
689{ 689{
690 size_t v = n + offset; 690 struct page *head = compound_head(page);
691 if (likely(n <= v && v <= (PAGE_SIZE << compound_order(page)))) 691 size_t v = n + offset + page_address(page) - page_address(head);
692
693 if (likely(n <= v && v <= (PAGE_SIZE << compound_order(head))))
692 return true; 694 return true;
693 WARN_ON(1); 695 WARN_ON(1);
694 return false; 696 return false;