diff options
| author | Quentin Lambert <lambert.quentin@gmail.com> | 2015-06-30 17:58:04 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-06-30 22:44:57 -0400 |
| commit | 43abdbcecea0673fa7f2f04422b57765935b2d5b (patch) | |
| tree | 6da37eead6ff39d6ea8b45b30b7026d6678560f4 | |
| parent | 196a4f82bddb2c4cb23736c5d467abcb9e716c63 (diff) | |
memstick: remove deprecated use of pci api
Replace occurences of the pci api by appropriate call to the dma api.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@deprecated@
idexpression id;
position p;
@@
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@bad1@
idexpression id;
position deprecated.p;
@@
...when != &id->dev
when != pci_get_drvdata ( id )
when != pci_enable_device ( id )
(
pci_dma_supported@p ( id, ...)
|
pci_alloc_consistent@p ( id, ...)
)
@depends on !bad1@
idexpression id;
expression direction;
position deprecated.p;
@@
(
- pci_dma_supported@p ( id,
+ dma_supported ( &id->dev,
...
+ , GFP_ATOMIC
)
|
- pci_alloc_consistent@p ( id,
+ dma_alloc_coherent ( &id->dev,
...
+ , GFP_ATOMIC
)
)
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | drivers/memstick/host/jmb38x_ms.c | 12 | ||||
| -rw-r--r-- | drivers/memstick/host/r592.c | 10 |
2 files changed, 11 insertions, 11 deletions
diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index aeabaa5aedf7..48db922075e2 100644 --- a/drivers/memstick/host/jmb38x_ms.c +++ b/drivers/memstick/host/jmb38x_ms.c | |||
| @@ -419,10 +419,10 @@ static int jmb38x_ms_issue_cmd(struct memstick_host *msh) | |||
| 419 | } | 419 | } |
| 420 | 420 | ||
| 421 | if (host->cmd_flags & DMA_DATA) { | 421 | if (host->cmd_flags & DMA_DATA) { |
| 422 | if (1 != pci_map_sg(host->chip->pdev, &host->req->sg, 1, | 422 | if (1 != dma_map_sg(&host->chip->pdev->dev, &host->req->sg, 1, |
| 423 | host->req->data_dir == READ | 423 | host->req->data_dir == READ |
| 424 | ? PCI_DMA_FROMDEVICE | 424 | ? DMA_FROM_DEVICE |
| 425 | : PCI_DMA_TODEVICE)) { | 425 | : DMA_TO_DEVICE)) { |
| 426 | host->req->error = -ENOMEM; | 426 | host->req->error = -ENOMEM; |
| 427 | return host->req->error; | 427 | return host->req->error; |
| 428 | } | 428 | } |
| @@ -487,9 +487,9 @@ static void jmb38x_ms_complete_cmd(struct memstick_host *msh, int last) | |||
| 487 | writel(0, host->addr + DMA_CONTROL); | 487 | writel(0, host->addr + DMA_CONTROL); |
| 488 | 488 | ||
| 489 | if (host->cmd_flags & DMA_DATA) { | 489 | if (host->cmd_flags & DMA_DATA) { |
| 490 | pci_unmap_sg(host->chip->pdev, &host->req->sg, 1, | 490 | dma_unmap_sg(&host->chip->pdev->dev, &host->req->sg, 1, |
| 491 | host->req->data_dir == READ | 491 | host->req->data_dir == READ |
| 492 | ? PCI_DMA_FROMDEVICE : PCI_DMA_TODEVICE); | 492 | ? DMA_FROM_DEVICE : DMA_TO_DEVICE); |
| 493 | } else { | 493 | } else { |
| 494 | t_val = readl(host->addr + INT_STATUS_ENABLE); | 494 | t_val = readl(host->addr + INT_STATUS_ENABLE); |
| 495 | if (host->req->data_dir == READ) | 495 | if (host->req->data_dir == READ) |
| @@ -925,7 +925,7 @@ static int jmb38x_ms_probe(struct pci_dev *pdev, | |||
| 925 | int pci_dev_busy = 0; | 925 | int pci_dev_busy = 0; |
| 926 | int rc, cnt; | 926 | int rc, cnt; |
| 927 | 927 | ||
| 928 | rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); | 928 | rc = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); |
| 929 | if (rc) | 929 | if (rc) |
| 930 | return rc; | 930 | return rc; |
| 931 | 931 | ||
diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c index e2a4f5f415b2..ef09ba0289d7 100644 --- a/drivers/memstick/host/r592.c +++ b/drivers/memstick/host/r592.c | |||
| @@ -754,7 +754,7 @@ static int r592_probe(struct pci_dev *pdev, const struct pci_device_id *id) | |||
| 754 | goto error2; | 754 | goto error2; |
| 755 | 755 | ||
| 756 | pci_set_master(pdev); | 756 | pci_set_master(pdev); |
| 757 | error = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); | 757 | error = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32)); |
| 758 | if (error) | 758 | if (error) |
| 759 | goto error3; | 759 | goto error3; |
| 760 | 760 | ||
| @@ -787,8 +787,8 @@ static int r592_probe(struct pci_dev *pdev, const struct pci_device_id *id) | |||
| 787 | } | 787 | } |
| 788 | 788 | ||
| 789 | /* This is just a precation, so don't fail */ | 789 | /* This is just a precation, so don't fail */ |
| 790 | dev->dummy_dma_page = pci_alloc_consistent(pdev, PAGE_SIZE, | 790 | dev->dummy_dma_page = dma_alloc_coherent(&pdev->dev, PAGE_SIZE, |
| 791 | &dev->dummy_dma_page_physical_address); | 791 | &dev->dummy_dma_page_physical_address, GFP_KERNEL); |
| 792 | r592_stop_dma(dev , 0); | 792 | r592_stop_dma(dev , 0); |
| 793 | 793 | ||
| 794 | if (request_irq(dev->irq, &r592_irq, IRQF_SHARED, | 794 | if (request_irq(dev->irq, &r592_irq, IRQF_SHARED, |
| @@ -805,7 +805,7 @@ error7: | |||
| 805 | free_irq(dev->irq, dev); | 805 | free_irq(dev->irq, dev); |
| 806 | error6: | 806 | error6: |
| 807 | if (dev->dummy_dma_page) | 807 | if (dev->dummy_dma_page) |
| 808 | pci_free_consistent(pdev, PAGE_SIZE, dev->dummy_dma_page, | 808 | dma_free_coherent(&pdev->dev, PAGE_SIZE, dev->dummy_dma_page, |
| 809 | dev->dummy_dma_page_physical_address); | 809 | dev->dummy_dma_page_physical_address); |
| 810 | 810 | ||
| 811 | kthread_stop(dev->io_thread); | 811 | kthread_stop(dev->io_thread); |
| @@ -845,7 +845,7 @@ static void r592_remove(struct pci_dev *pdev) | |||
| 845 | memstick_free_host(dev->host); | 845 | memstick_free_host(dev->host); |
| 846 | 846 | ||
| 847 | if (dev->dummy_dma_page) | 847 | if (dev->dummy_dma_page) |
| 848 | pci_free_consistent(pdev, PAGE_SIZE, dev->dummy_dma_page, | 848 | dma_free_coherent(&pdev->dev, PAGE_SIZE, dev->dummy_dma_page, |
| 849 | dev->dummy_dma_page_physical_address); | 849 | dev->dummy_dma_page_physical_address); |
| 850 | } | 850 | } |
| 851 | 851 | ||
