diff options
author | Hans de Goede <hdegoede@redhat.com> | 2018-10-12 06:12:28 -0400 |
---|---|---|
committer | Thierry Reding <thierry.reding@gmail.com> | 2018-10-12 06:32:12 -0400 |
commit | 42885551cedb45961879d2fc3dc3c4dc545cc23e (patch) | |
tree | d6ef2e64ef72bab8aefc6e6c4627d623359326e6 | |
parent | 6a425ecd19a2c0e19a501323216ecf987de07841 (diff) |
pwm: lpss: Release runtime-pm reference from the driver's remove callback
For each pwm output which gets enabled through pwm_lpss_apply(), we do a
pm_runtime_get_sync().
This commit adds pm_runtime_put() calls to pwm_lpss_remove() to balance
these when the driver gets removed with some of the outputs still enabled.
Fixes: f080be27d7d9 ("pwm: lpss: Add support for runtime PM")
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
-rw-r--r-- | drivers/pwm/pwm-lpss.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c index e602835fd6de..723ca9de8325 100644 --- a/drivers/pwm/pwm-lpss.c +++ b/drivers/pwm/pwm-lpss.c | |||
@@ -205,6 +205,12 @@ EXPORT_SYMBOL_GPL(pwm_lpss_probe); | |||
205 | 205 | ||
206 | int pwm_lpss_remove(struct pwm_lpss_chip *lpwm) | 206 | int pwm_lpss_remove(struct pwm_lpss_chip *lpwm) |
207 | { | 207 | { |
208 | int i; | ||
209 | |||
210 | for (i = 0; i < lpwm->info->npwm; i++) { | ||
211 | if (pwm_is_enabled(&lpwm->chip.pwms[i])) | ||
212 | pm_runtime_put(lpwm->chip.dev); | ||
213 | } | ||
208 | return pwmchip_remove(&lpwm->chip); | 214 | return pwmchip_remove(&lpwm->chip); |
209 | } | 215 | } |
210 | EXPORT_SYMBOL_GPL(pwm_lpss_remove); | 216 | EXPORT_SYMBOL_GPL(pwm_lpss_remove); |