diff options
author | Sebastian Capella <sebastian.capella@linaro.org> | 2014-02-14 17:52:56 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2014-02-28 19:02:52 -0500 |
commit | 421a5fa1a6cfc037a21220b638d4def6da7cbabe (patch) | |
tree | eb9ea452e08d8bac508125a9b5709abcc417c6d9 | |
parent | 6c5be2916565e8c710e9f0f7b43cf65a3ba39dd9 (diff) |
PM / hibernate: use name_to_dev_t to parse resume
Use the name_to_dev_t call to parse the device name echo'd to
to /sys/power/resume. This imitates the method used in hibernate.c
in software_resume, and allows the resume partition to be specified
using other equivalent device formats as well. By allowing
/sys/debug/resume to accept the same syntax as the resume=device
parameter, we can parse the resume=device in the init script and
use the resume device directly from the kernel command line.
Signed-off-by: Sebastian Capella <sebastian.capella@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
-rw-r--r-- | kernel/power/hibernate.c | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index 37170d4dd9a6..f4f2073711d3 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c | |||
@@ -973,16 +973,20 @@ static ssize_t resume_show(struct kobject *kobj, struct kobj_attribute *attr, | |||
973 | static ssize_t resume_store(struct kobject *kobj, struct kobj_attribute *attr, | 973 | static ssize_t resume_store(struct kobject *kobj, struct kobj_attribute *attr, |
974 | const char *buf, size_t n) | 974 | const char *buf, size_t n) |
975 | { | 975 | { |
976 | unsigned int maj, min; | ||
977 | dev_t res; | 976 | dev_t res; |
978 | int ret = -EINVAL; | 977 | int len = n; |
978 | char *name; | ||
979 | 979 | ||
980 | if (sscanf(buf, "%u:%u", &maj, &min) != 2) | 980 | if (len && buf[len-1] == '\n') |
981 | goto out; | 981 | len--; |
982 | name = kstrndup(buf, len, GFP_KERNEL); | ||
983 | if (!name) | ||
984 | return -ENOMEM; | ||
982 | 985 | ||
983 | res = MKDEV(maj,min); | 986 | res = name_to_dev_t(name); |
984 | if (maj != MAJOR(res) || min != MINOR(res)) | 987 | kfree(name); |
985 | goto out; | 988 | if (!res) |
989 | return -EINVAL; | ||
986 | 990 | ||
987 | lock_system_sleep(); | 991 | lock_system_sleep(); |
988 | swsusp_resume_device = res; | 992 | swsusp_resume_device = res; |
@@ -990,9 +994,7 @@ static ssize_t resume_store(struct kobject *kobj, struct kobj_attribute *attr, | |||
990 | printk(KERN_INFO "PM: Starting manual resume from disk\n"); | 994 | printk(KERN_INFO "PM: Starting manual resume from disk\n"); |
991 | noresume = 0; | 995 | noresume = 0; |
992 | software_resume(); | 996 | software_resume(); |
993 | ret = n; | 997 | return n; |
994 | out: | ||
995 | return ret; | ||
996 | } | 998 | } |
997 | 999 | ||
998 | power_attr(resume); | 1000 | power_attr(resume); |