aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorParav Pandit <parav@mellanox.com>2017-02-28 00:21:02 -0500
committerJens Axboe <axboe@fb.com>2017-04-04 11:48:23 -0400
commit4151dd9a58c6b2758514fc88a1a3b02f9ab8b076 (patch)
tree8d02b78871a0de940662498eb6ecaa05a16105f1
parent4459e042970b33b94ef0e2426ee22edf233da2f5 (diff)
nvmet: Fixed avoided printing nvmet: twice in error logs.
This patch avoids printing "nvmet:" twice in error logs as its already coming through pr_fmt macro. Reviewed-by: Max Gurtovoy <maxg@mellanox.com> Signed-off-by: Parav Pandit <parav@mellanox.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sagi Grimberg <sagi@grimberg.me> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--drivers/nvme/target/admin-cmd.c10
-rw-r--r--drivers/nvme/target/core.c4
-rw-r--r--drivers/nvme/target/discovery.c17
-rw-r--r--drivers/nvme/target/io-cmd.c10
4 files changed, 20 insertions, 21 deletions
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index a7bcff45f437..42b8bba97e7d 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -487,13 +487,13 @@ int nvmet_parse_admin_cmd(struct nvmet_req *req)
487 req->ns = NULL; 487 req->ns = NULL;
488 488
489 if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) { 489 if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) {
490 pr_err("nvmet: got admin cmd %d while CC.EN == 0\n", 490 pr_err("got admin cmd %d while CC.EN == 0\n",
491 cmd->common.opcode); 491 cmd->common.opcode);
492 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR; 492 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
493 } 493 }
494 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) { 494 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) {
495 pr_err("nvmet: got admin cmd %d while CSTS.RDY == 0\n", 495 pr_err("got admin cmd %d while CSTS.RDY == 0\n",
496 cmd->common.opcode); 496 cmd->common.opcode);
497 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR; 497 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
498 } 498 }
499 499
@@ -545,6 +545,6 @@ int nvmet_parse_admin_cmd(struct nvmet_req *req)
545 return 0; 545 return 0;
546 } 546 }
547 547
548 pr_err("nvmet: unhandled cmd %d\n", cmd->common.opcode); 548 pr_err("unhandled cmd %d\n", cmd->common.opcode);
549 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 549 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
550} 550}
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index 798653b329b2..2536119a580d 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -273,8 +273,8 @@ int nvmet_ns_enable(struct nvmet_ns *ns)
273 ns->bdev = blkdev_get_by_path(ns->device_path, FMODE_READ | FMODE_WRITE, 273 ns->bdev = blkdev_get_by_path(ns->device_path, FMODE_READ | FMODE_WRITE,
274 NULL); 274 NULL);
275 if (IS_ERR(ns->bdev)) { 275 if (IS_ERR(ns->bdev)) {
276 pr_err("nvmet: failed to open block device %s: (%ld)\n", 276 pr_err("failed to open block device %s: (%ld)\n",
277 ns->device_path, PTR_ERR(ns->bdev)); 277 ns->device_path, PTR_ERR(ns->bdev));
278 ret = PTR_ERR(ns->bdev); 278 ret = PTR_ERR(ns->bdev);
279 ns->bdev = NULL; 279 ns->bdev = NULL;
280 goto out_unlock; 280 goto out_unlock;
diff --git a/drivers/nvme/target/discovery.c b/drivers/nvme/target/discovery.c
index af8aabf05335..745f26f35244 100644
--- a/drivers/nvme/target/discovery.c
+++ b/drivers/nvme/target/discovery.c
@@ -166,8 +166,8 @@ int nvmet_parse_discovery_cmd(struct nvmet_req *req)
166 req->ns = NULL; 166 req->ns = NULL;
167 167
168 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) { 168 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) {
169 pr_err("nvmet: got cmd %d while not ready\n", 169 pr_err("got cmd %d while not ready\n",
170 cmd->common.opcode); 170 cmd->common.opcode);
171 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 171 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
172 } 172 }
173 173
@@ -180,8 +180,8 @@ int nvmet_parse_discovery_cmd(struct nvmet_req *req)
180 req->execute = nvmet_execute_get_disc_log_page; 180 req->execute = nvmet_execute_get_disc_log_page;
181 return 0; 181 return 0;
182 default: 182 default:
183 pr_err("nvmet: unsupported get_log_page lid %d\n", 183 pr_err("unsupported get_log_page lid %d\n",
184 cmd->get_log_page.lid); 184 cmd->get_log_page.lid);
185 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 185 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
186 } 186 }
187 case nvme_admin_identify: 187 case nvme_admin_identify:
@@ -192,17 +192,16 @@ int nvmet_parse_discovery_cmd(struct nvmet_req *req)
192 nvmet_execute_identify_disc_ctrl; 192 nvmet_execute_identify_disc_ctrl;
193 return 0; 193 return 0;
194 default: 194 default:
195 pr_err("nvmet: unsupported identify cns %d\n", 195 pr_err("unsupported identify cns %d\n",
196 cmd->identify.cns); 196 cmd->identify.cns);
197 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 197 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
198 } 198 }
199 default: 199 default:
200 pr_err("nvmet: unsupported cmd %d\n", 200 pr_err("unsupported cmd %d\n", cmd->common.opcode);
201 cmd->common.opcode);
202 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 201 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
203 } 202 }
204 203
205 pr_err("nvmet: unhandled cmd %d\n", cmd->common.opcode); 204 pr_err("unhandled cmd %d\n", cmd->common.opcode);
206 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 205 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
207} 206}
208 207
diff --git a/drivers/nvme/target/io-cmd.c b/drivers/nvme/target/io-cmd.c
index 4195115c7e54..190b68741a6a 100644
--- a/drivers/nvme/target/io-cmd.c
+++ b/drivers/nvme/target/io-cmd.c
@@ -201,15 +201,15 @@ int nvmet_parse_io_cmd(struct nvmet_req *req)
201 struct nvme_command *cmd = req->cmd; 201 struct nvme_command *cmd = req->cmd;
202 202
203 if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) { 203 if (unlikely(!(req->sq->ctrl->cc & NVME_CC_ENABLE))) {
204 pr_err("nvmet: got io cmd %d while CC.EN == 0\n", 204 pr_err("got io cmd %d while CC.EN == 0\n",
205 cmd->common.opcode); 205 cmd->common.opcode);
206 req->ns = NULL; 206 req->ns = NULL;
207 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR; 207 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
208 } 208 }
209 209
210 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) { 210 if (unlikely(!(req->sq->ctrl->csts & NVME_CSTS_RDY))) {
211 pr_err("nvmet: got io cmd %d while CSTS.RDY == 0\n", 211 pr_err("got io cmd %d while CSTS.RDY == 0\n",
212 cmd->common.opcode); 212 cmd->common.opcode);
213 req->ns = NULL; 213 req->ns = NULL;
214 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR; 214 return NVME_SC_CMD_SEQ_ERROR | NVME_SC_DNR;
215 } 215 }
@@ -237,7 +237,7 @@ int nvmet_parse_io_cmd(struct nvmet_req *req)
237 req->execute = nvmet_execute_write_zeroes; 237 req->execute = nvmet_execute_write_zeroes;
238 return 0; 238 return 0;
239 default: 239 default:
240 pr_err("nvmet: unhandled cmd %d\n", cmd->common.opcode); 240 pr_err("unhandled cmd %d\n", cmd->common.opcode);
241 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; 241 return NVME_SC_INVALID_OPCODE | NVME_SC_DNR;
242 } 242 }
243} 243}