aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMeghana Madhyastha <meghana.madhyastha@gmail.com>2018-01-24 11:34:48 -0500
committerSean Paul <seanpaul@chromium.org>2018-02-20 11:07:22 -0500
commit414147e8a3870ff0f7fbd8dc3a33029d6aab1b02 (patch)
tree9a0a61ef7d50066bb96f34411ea707ef4551537c
parentf5155876af19f885fec94bbb926b0ce62115e139 (diff)
drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable
Remove tinydrm_enable/disable_backlight and let the callers call the more generic backlight_enable/disable helpers Reviewed-by: Noralf Trønnes <noralf@tronnes.org> Reviewed-by: Sean Paul <seanpaul@chromium.org> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/ec700724e47814e6426966e093bd32b2364ba147.1516810725.git.meghana.madhyastha@gmail.com
-rw-r--r--drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c55
-rw-r--r--drivers/gpu/drm/tinydrm/mipi-dbi.c4
-rw-r--r--include/drm/tinydrm/tinydrm-helpers.h2
3 files changed, 2 insertions, 59 deletions
diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c b/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
index bf96072d1b97..7326e1758bac 100644
--- a/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
+++ b/drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c
@@ -276,61 +276,6 @@ struct backlight_device *tinydrm_of_find_backlight(struct device *dev)
276} 276}
277EXPORT_SYMBOL(tinydrm_of_find_backlight); 277EXPORT_SYMBOL(tinydrm_of_find_backlight);
278 278
279/**
280 * tinydrm_enable_backlight - Enable backlight helper
281 * @backlight: Backlight device
282 *
283 * Returns:
284 * Zero on success, negative error code on failure.
285 */
286int tinydrm_enable_backlight(struct backlight_device *backlight)
287{
288 unsigned int old_state;
289 int ret;
290
291 if (!backlight)
292 return 0;
293
294 old_state = backlight->props.state;
295 backlight->props.state &= ~BL_CORE_FBBLANK;
296 DRM_DEBUG_KMS("Backlight state: 0x%x -> 0x%x\n", old_state,
297 backlight->props.state);
298
299 ret = backlight_update_status(backlight);
300 if (ret)
301 DRM_ERROR("Failed to enable backlight %d\n", ret);
302
303 return ret;
304}
305EXPORT_SYMBOL(tinydrm_enable_backlight);
306
307/**
308 * tinydrm_disable_backlight - Disable backlight helper
309 * @backlight: Backlight device
310 *
311 * Returns:
312 * Zero on success, negative error code on failure.
313 */
314int tinydrm_disable_backlight(struct backlight_device *backlight)
315{
316 unsigned int old_state;
317 int ret;
318
319 if (!backlight)
320 return 0;
321
322 old_state = backlight->props.state;
323 backlight->props.state |= BL_CORE_FBBLANK;
324 DRM_DEBUG_KMS("Backlight state: 0x%x -> 0x%x\n", old_state,
325 backlight->props.state);
326 ret = backlight_update_status(backlight);
327 if (ret)
328 DRM_ERROR("Failed to disable backlight %d\n", ret);
329
330 return ret;
331}
332EXPORT_SYMBOL(tinydrm_disable_backlight);
333
334#if IS_ENABLED(CONFIG_SPI) 279#if IS_ENABLED(CONFIG_SPI)
335 280
336/** 281/**
diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c
index 75dd65c57e74..9e903812b573 100644
--- a/drivers/gpu/drm/tinydrm/mipi-dbi.c
+++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c
@@ -286,7 +286,7 @@ void mipi_dbi_enable_flush(struct mipi_dbi *mipi)
286 if (fb) 286 if (fb)
287 fb->funcs->dirty(fb, NULL, 0, 0, NULL, 0); 287 fb->funcs->dirty(fb, NULL, 0, 0, NULL, 0);
288 288
289 tinydrm_enable_backlight(mipi->backlight); 289 backlight_enable(mipi->backlight);
290} 290}
291EXPORT_SYMBOL(mipi_dbi_enable_flush); 291EXPORT_SYMBOL(mipi_dbi_enable_flush);
292 292
@@ -325,7 +325,7 @@ void mipi_dbi_pipe_disable(struct drm_simple_display_pipe *pipe)
325 mipi->enabled = false; 325 mipi->enabled = false;
326 326
327 if (mipi->backlight) 327 if (mipi->backlight)
328 tinydrm_disable_backlight(mipi->backlight); 328 backlight_disable(mipi->backlight);
329 else 329 else
330 mipi_dbi_blank(mipi); 330 mipi_dbi_blank(mipi);
331 331
diff --git a/include/drm/tinydrm/tinydrm-helpers.h b/include/drm/tinydrm/tinydrm-helpers.h
index d554ded60ee9..f54fae03e34e 100644
--- a/include/drm/tinydrm/tinydrm-helpers.h
+++ b/include/drm/tinydrm/tinydrm-helpers.h
@@ -47,8 +47,6 @@ void tinydrm_xrgb8888_to_gray8(u8 *dst, void *vaddr, struct drm_framebuffer *fb,
47 struct drm_clip_rect *clip); 47 struct drm_clip_rect *clip);
48 48
49struct backlight_device *tinydrm_of_find_backlight(struct device *dev); 49struct backlight_device *tinydrm_of_find_backlight(struct device *dev);
50int tinydrm_enable_backlight(struct backlight_device *backlight);
51int tinydrm_disable_backlight(struct backlight_device *backlight);
52 50
53size_t tinydrm_spi_max_transfer_size(struct spi_device *spi, size_t max_len); 51size_t tinydrm_spi_max_transfer_size(struct spi_device *spi, size_t max_len);
54bool tinydrm_spi_bpw_supported(struct spi_device *spi, u8 bpw); 52bool tinydrm_spi_bpw_supported(struct spi_device *spi, u8 bpw);