aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2017-02-07 12:59:21 -0500
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2017-02-07 17:31:45 -0500
commit413d37326700aaf708730b940b04192c36e13ef4 (patch)
treeb31f87b933d437d7f1754dfb983f3b33b7296a2e
parent601bbbe0517303c9f8eb3d75e11d64efed1293c9 (diff)
Input: synaptics-rmi4 - select 'SERIO' when needed
With CONFIG_SERIO=m, we get a build error for the rmi4-f03 driver, added in linux-4.10: warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies (!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO)) drivers/input/built-in.o: In function `rmi_f03_attention': rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt' rmi_f03.c:(.text+0xd055): undefined reference to `serio_interrupt' drivers/input/built-in.o: In function `rmi_f03_remove': rmi_f03.c:(.text+0xd115): undefined reference to `serio_unregister_port' drivers/input/built-in.o: In function `rmi_f03_probe': rmi_f03.c:(.text+0xd209): undefined reference to `__serio_register_port' An earlier patch tried to fix this, but missed the HID_RMI driver that does a 'select' on the F03 backend. This adds a hidden Kconfig symbol that enforces 'serio' to be enabled when RMI4-F03 is, which covers all cases. Fixes: d7ddad0acc4a ("Input: synaptics-rmi4 - fix F03 build error when serio is module") Fixes: c5e8848fc98e ("Input: synaptics-rmi4 - add support for F03") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/rmi4/Kconfig8
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig
index 8993983e3fe4..bb7762bf2879 100644
--- a/drivers/input/rmi4/Kconfig
+++ b/drivers/input/rmi4/Kconfig
@@ -42,13 +42,19 @@ config RMI4_SMB
42config RMI4_F03 42config RMI4_F03
43 bool "RMI4 Function 03 (PS2 Guest)" 43 bool "RMI4 Function 03 (PS2 Guest)"
44 depends on RMI4_CORE 44 depends on RMI4_CORE
45 depends on SERIO=y || RMI4_CORE=SERIO
46 help 45 help
47 Say Y here if you want to add support for RMI4 function 03. 46 Say Y here if you want to add support for RMI4 function 03.
48 47
49 Function 03 provides PS2 guest support for RMI4 devices. This 48 Function 03 provides PS2 guest support for RMI4 devices. This
50 includes support for TrackPoints on TouchPads. 49 includes support for TrackPoints on TouchPads.
51 50
51config RMI4_F03_SERIO
52 tristate
53 depends on RMI4_CORE
54 depends on RMI4_F03
55 default RMI4_CORE
56 select SERIO
57
52config RMI4_2D_SENSOR 58config RMI4_2D_SENSOR
53 bool 59 bool
54 depends on RMI4_CORE 60 depends on RMI4_CORE