aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorShreyas NC <shreyas.nc@intel.com>2018-07-27 05:14:09 -0400
committerVinod Koul <vkoul@kernel.org>2018-08-27 00:19:48 -0400
commit3fef1a2259c556cce34df2791688cb3001f81c92 (patch)
treea48864594dd14faa7d0fda5a7a1319ecd14632bc
parent0aebe40bae6cf5652fdc3d05ecee15fbf5748194 (diff)
soundwire: Fix incorrect exit after configuring stream
In sdw_stream_add_master() after the Master ports are configured, the stream is released incorrectly. So, fix it by avoiding stream release after configuring the Master for the stream. While at it, rename the label appropriately. Signed-off-by: Shreyas NC <shreyas.nc@intel.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r--drivers/soundwire/stream.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 7ba6d4d8cd03..b2682272503e 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -1112,7 +1112,7 @@ int sdw_stream_add_master(struct sdw_bus *bus,
1112 "Master runtime config failed for stream:%s", 1112 "Master runtime config failed for stream:%s",
1113 stream->name); 1113 stream->name);
1114 ret = -ENOMEM; 1114 ret = -ENOMEM;
1115 goto error; 1115 goto unlock;
1116 } 1116 }
1117 1117
1118 ret = sdw_config_stream(bus->dev, stream, stream_config, false); 1118 ret = sdw_config_stream(bus->dev, stream, stream_config, false);
@@ -1123,9 +1123,11 @@ int sdw_stream_add_master(struct sdw_bus *bus,
1123 if (ret) 1123 if (ret)
1124 goto stream_error; 1124 goto stream_error;
1125 1125
1126 goto unlock;
1127
1126stream_error: 1128stream_error:
1127 sdw_release_master_stream(stream); 1129 sdw_release_master_stream(stream);
1128error: 1130unlock:
1129 mutex_unlock(&bus->bus_lock); 1131 mutex_unlock(&bus->bus_lock);
1130 return ret; 1132 return ret;
1131} 1133}