aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Meyer <thomas@m3y3r.de>2017-10-07 10:02:21 -0400
committerChristoph Hellwig <hch@lst.de>2017-10-19 10:15:14 -0400
commit3f6928c347707a65cee10a9f54b85ad5fb078b3f (patch)
treef6aa17b00fef7beba0d85e49c8f4dc04dde21c22
parent33d930e59a98fa10a0db9f56c7fa2f21a4aef9b9 (diff)
configfs: Fix bool initialization/comparison
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r--fs/configfs/file.c12
1 files changed, 6 insertions, 6 deletions
diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index 39da1103d341..62580dba3552 100644
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -166,7 +166,7 @@ configfs_read_bin_file(struct file *file, char __user *buf,
166 retval = -ETXTBSY; 166 retval = -ETXTBSY;
167 goto out; 167 goto out;
168 } 168 }
169 buffer->read_in_progress = 1; 169 buffer->read_in_progress = true;
170 170
171 if (buffer->needs_read_fill) { 171 if (buffer->needs_read_fill) {
172 /* perform first read with buf == NULL to get extent */ 172 /* perform first read with buf == NULL to get extent */
@@ -325,7 +325,7 @@ configfs_write_bin_file(struct file *file, const char __user *buf,
325 len = -ETXTBSY; 325 len = -ETXTBSY;
326 goto out; 326 goto out;
327 } 327 }
328 buffer->write_in_progress = 1; 328 buffer->write_in_progress = true;
329 329
330 /* buffer grows? */ 330 /* buffer grows? */
331 if (*ppos + count > buffer->bin_buffer_size) { 331 if (*ppos + count > buffer->bin_buffer_size) {
@@ -429,8 +429,8 @@ static int check_perm(struct inode * inode, struct file * file, int type)
429 } 429 }
430 mutex_init(&buffer->mutex); 430 mutex_init(&buffer->mutex);
431 buffer->needs_read_fill = 1; 431 buffer->needs_read_fill = 1;
432 buffer->read_in_progress = 0; 432 buffer->read_in_progress = false;
433 buffer->write_in_progress = 0; 433 buffer->write_in_progress = false;
434 buffer->ops = ops; 434 buffer->ops = ops;
435 file->private_data = buffer; 435 file->private_data = buffer;
436 goto Done; 436 goto Done;
@@ -488,10 +488,10 @@ static int configfs_release_bin_file(struct inode *inode, struct file *filp)
488 ssize_t len = 0; 488 ssize_t len = 0;
489 int ret; 489 int ret;
490 490
491 buffer->read_in_progress = 0; 491 buffer->read_in_progress = false;
492 492
493 if (buffer->write_in_progress) { 493 if (buffer->write_in_progress) {
494 buffer->write_in_progress = 0; 494 buffer->write_in_progress = false;
495 495
496 len = bin_attr->write(item, buffer->bin_buffer, 496 len = bin_attr->write(item, buffer->bin_buffer,
497 buffer->bin_buffer_size); 497 buffer->bin_buffer_size);