diff options
author | Jiri Olsa <jolsa@kernel.org> | 2015-06-03 10:25:54 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-06-08 09:30:30 -0400 |
commit | 3e99e2f5e78e601591dbcf777c67a84aa9ea2ae5 (patch) | |
tree | e21410c5bf1100dbd799f13f03e260ff50425bab | |
parent | a454742c1252d6242e00b5f4f6f9e5fbce3859d7 (diff) |
perf stat: Remove transaction_run from shadow update/print code
It's no longer needed, because we use nameid to recognize transaction
events.
Keeping it only in stat code to initialize transaction events.
I.e. struct perf_stat::id, accessible via evsel->priv, will be only set
for transaction related events.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1433341559-31848-5-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/builtin-stat.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 0c0071cf4fba..b3e08ce2c564 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c | |||
@@ -355,11 +355,11 @@ static void update_shadow_stats(struct perf_evsel *counter, u64 *count, | |||
355 | update_stats(&runtime_nsecs_stats[cpu], count[0]); | 355 | update_stats(&runtime_nsecs_stats[cpu], count[0]); |
356 | else if (perf_evsel__match(counter, HARDWARE, HW_CPU_CYCLES)) | 356 | else if (perf_evsel__match(counter, HARDWARE, HW_CPU_CYCLES)) |
357 | update_stats(&runtime_cycles_stats[ctx][cpu], count[0]); | 357 | update_stats(&runtime_cycles_stats[ctx][cpu], count[0]); |
358 | else if (transaction_run && perf_stat_evsel__is(counter, CYCLES_IN_TX)) | 358 | else if (perf_stat_evsel__is(counter, CYCLES_IN_TX)) |
359 | update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); | 359 | update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); |
360 | else if (transaction_run && perf_stat_evsel__is(counter, TRANSACTION_START)) | 360 | else if (perf_stat_evsel__is(counter, TRANSACTION_START)) |
361 | update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); | 361 | update_stats(&runtime_transaction_stats[ctx][cpu], count[0]); |
362 | else if (transaction_run && perf_stat_evsel__is(counter, ELISION_START)) | 362 | else if (perf_stat_evsel__is(counter, ELISION_START)) |
363 | update_stats(&runtime_elision_stats[ctx][cpu], count[0]); | 363 | update_stats(&runtime_elision_stats[ctx][cpu], count[0]); |
364 | else if (perf_evsel__match(counter, HARDWARE, HW_STALLED_CYCLES_FRONTEND)) | 364 | else if (perf_evsel__match(counter, HARDWARE, HW_STALLED_CYCLES_FRONTEND)) |
365 | update_stats(&runtime_stalled_cycles_front_stats[ctx][cpu], count[0]); | 365 | update_stats(&runtime_stalled_cycles_front_stats[ctx][cpu], count[0]); |
@@ -1170,13 +1170,13 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg) | |||
1170 | } else { | 1170 | } else { |
1171 | fprintf(output, " "); | 1171 | fprintf(output, " "); |
1172 | } | 1172 | } |
1173 | } else if (transaction_run && perf_stat_evsel__is(evsel, CYCLES_IN_TX)) { | 1173 | } else if (perf_stat_evsel__is(evsel, CYCLES_IN_TX)) { |
1174 | total = avg_stats(&runtime_cycles_stats[ctx][cpu]); | 1174 | total = avg_stats(&runtime_cycles_stats[ctx][cpu]); |
1175 | if (total) | 1175 | if (total) |
1176 | fprintf(output, | 1176 | fprintf(output, |
1177 | " # %5.2f%% transactional cycles ", | 1177 | " # %5.2f%% transactional cycles ", |
1178 | 100.0 * (avg / total)); | 1178 | 100.0 * (avg / total)); |
1179 | } else if (transaction_run && perf_stat_evsel__is(evsel, CYCLES_IN_TX_CP)) { | 1179 | } else if (perf_stat_evsel__is(evsel, CYCLES_IN_TX_CP)) { |
1180 | total = avg_stats(&runtime_cycles_stats[ctx][cpu]); | 1180 | total = avg_stats(&runtime_cycles_stats[ctx][cpu]); |
1181 | total2 = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); | 1181 | total2 = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); |
1182 | if (total2 < avg) | 1182 | if (total2 < avg) |
@@ -1185,7 +1185,7 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg) | |||
1185 | fprintf(output, | 1185 | fprintf(output, |
1186 | " # %5.2f%% aborted cycles ", | 1186 | " # %5.2f%% aborted cycles ", |
1187 | 100.0 * ((total2-avg) / total)); | 1187 | 100.0 * ((total2-avg) / total)); |
1188 | } else if (transaction_run && perf_stat_evsel__is(evsel, TRANSACTION_START) && | 1188 | } else if (perf_stat_evsel__is(evsel, TRANSACTION_START) && |
1189 | avg > 0 && | 1189 | avg > 0 && |
1190 | runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { | 1190 | runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { |
1191 | total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); | 1191 | total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); |
@@ -1194,7 +1194,7 @@ static void abs_printout(int id, int nr, struct perf_evsel *evsel, double avg) | |||
1194 | ratio = total / avg; | 1194 | ratio = total / avg; |
1195 | 1195 | ||
1196 | fprintf(output, " # %8.0f cycles / transaction ", ratio); | 1196 | fprintf(output, " # %8.0f cycles / transaction ", ratio); |
1197 | } else if (transaction_run && perf_stat_evsel__is(evsel, ELISION_START) && | 1197 | } else if (perf_stat_evsel__is(evsel, ELISION_START) && |
1198 | avg > 0 && | 1198 | avg > 0 && |
1199 | runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { | 1199 | runtime_cycles_in_tx_stats[ctx][cpu].n != 0) { |
1200 | total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); | 1200 | total = avg_stats(&runtime_cycles_in_tx_stats[ctx][cpu]); |